Skip to content

fix(runtime): remove redundant runtime declarations #14993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LingyuCoder merged 1 commit into from
Jul 31, 2026
Merged

fix(runtime): remove redundant runtime declarations #14993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/rspack_core/src/runtime_module.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ pub fn runtime_module_owned_define_fields(
let runtime_requirements = runtime_module.runtime_requirements(compilation);
let define_fields = runtime_requirements
.define
.difference(RuntimeGlobals::STARTUP | runtime_requirements.force_context);
.difference(RuntimeGlobals::STARTUP);
fields | define_fields
})
}
Expand Down
1 change: 0 additions & 1 deletion ...t/esmOutputCases/basic/split-runtime-chunk/__snapshots__/runtimeModeSnapshot/esm.snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ export { rspackRequire };
var moduleFactories = modules;
export { moduleFactories };

var publicPath, scriptNonce;
// rspack/runtime/esm_register_module
moduleFactories.add = function registerModules(modules) { Object.assign(moduleFactories, modules) }
;
Expand Down
2 changes: 1 addition & 1 deletion ...putCases/dynamic-import/import-context-css/__snapshots__/runtimeModeSnapshot/esm.snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export { rspackRequire };
var moduleFactories = modules;
export { moduleFactories };

var publicPath, scriptNonce;
var scriptNonce;
// rspack/runtime/define_property_getters
var definePropertyGetters = (exports, getters, values) => {
var define = (defs, kind) => {
Expand Down
2 changes: 1 addition & 1 deletion ...mic-import/import-context-prefetch-preload/__snapshots__/runtimeModeSnapshot/esm.snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ export { rspackRequire };
var moduleFactories = modules;
export { moduleFactories };

var publicPath, scriptNonce, prefetchChunk, preloadChunk;
var scriptNonce;
// rspack/runtime/define_property_getters
var definePropertyGetters = (exports, getters, values) => {
var define = (defs, kind) => {
Expand Down
Binary file modified ...test/esmOutputCases/preserve-modules/asset/__snapshots__/runtimeModeSnapshot/esm.snap.txt
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion ...mOutputCases/worker/entry-module-execution/__snapshots__/runtimeModeSnapshot/esm.snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// The require scope
var rspackRequire = {};

var publicPath, hasOwnProperty, baseUri;
var hasOwnProperty, baseUri;
// rspack/runtime/get javascript chunk filename
// This function allow to reference chunks
var getChunkScriptFilename = (chunkId) => {
Expand Down
Loading