fix: preserve direct exports bindings - #15003
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 523819a06e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
📦 Binary Size-limit
🙈 Size remains the same at 66.77MB |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Merging this PR will improve performance by 3.11%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | rust@persistent_cache_restore_after_single_file_change@basic-react-development |
4.8 ms | 4.7 ms | +3.23% |
| ⚡ | Simulation | rust@persistent_cache_restore@basic-react-development |
4.5 ms | 4.3 ms | +3.14% |
| ⚡ | Simulation | rust@create_chunk_assets |
1.5 ms | 1.4 ms | +2.96% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing seal/fix-rspack-exports-binding (45cf213) with main (c05244a)2
Footnotes
-
47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(727ca03) during the generation of this report, so c05244a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
523819a to
f215056
Compare
33d05e0 to
eb81ae3
Compare
Deploying rspack with
|
| Latest commit: |
45cf213
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f802f07a.rspack-v2.pages.dev |
| Branch Preview URL: | https://seal-fix-rspack-exports-bind.rspack-v2.pages.dev |
eb81ae3 to
2c6a4fc
Compare
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
2c6a4fc to
46c6731
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46c673186f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Pull Request is not mergeable
46c6731 to
45cf213
Compare
2 participants
Summary
__webpack_exports__withoutput.module: trueandlibrary.type: "modern-module"__webpack_exports__as the public ESM export name__webpack_exports__andexportsbindings across runtime render modesReproduction
Stack
Testing
cargo fmt --all --checkcargo check -p rspack_plugin_javascript --lib --lockedcargo clippy -p rspack_plugin_javascript --lib --locked -- -D warningscorepack pnpm@11.8.0 --filter @rspack/binding run build:devcorepack pnpm@11.8.0 --dir tests/rspack-test exec rs test EsmOutput.test.js RuntimeModeEsmOutput.test.js --testNamePattern 'deconflict/(exports-binding|webpack-exports-binding)'EsmOutput.test.jsandRuntimeModeEsmOutput.test.jssuites on fix: preserve runtime-free ESM binding names #15004 (506 tests)