perf: use numeric suffixes for faster concatenation - #15228
LingyuCoder wants to merge 12 commits into
Conversation
📦 Binary Size-limit
⏳ The base commit triggered a linux binding build, but its binary size data has not been generated yet, so the size comparison is skipped. Please re-run this workflow once the ecosystem-benchmark data for that commit is published. Warning Reference only — not the real baseline. The base commit's data isn't ready yet, so this compares against the nearest earlier commit that has data ( ❌ Size increased by 244.00KB from 68.20MB to 68.44MB (⬆️0.35%) |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 5 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 popular-libsPath:
📁 react-1kPath:
📁 react-10kPath:
📁 react-5kPath:
📁 ui-componentsPath:
Generated by Rsdoctor GitHub Action |
Merging this PR will improve performance by 25.06%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | rust@concatenate_module_code_generation |
33.7 ms | 26.9 ms | +25.06% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing seal/concat-numeric-suffix (5e6ff53) with seal/concat-local-ident (d84ab09)
Footnotes
-
47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Summary
This is an experimental follow-up to #14852 for measuring a smaller naming optimization against the indexed-name approach in #15222.
NameAllocatorandfind_new_namecollision handling.foo_0.Related links
Validation
cargo check -p rspack_corepnpm --filter @rspack/tests test FasterModuleConcatenation.test.js(84 passed)Checklist