fix: preserve reexport call context in concatenation - #15247
Merged
Merged
Conversation
LingyuCoder
marked this pull request as ready for review
August 19, 2026 07:22
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 68.11MB |
Contributor
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
LingyuCoder
enabled auto-merge (squash)
August 19, 2026 07:46
JSerFeng
approved these changes
Aug 19, 2026
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
this-sensitive default export.Faster module concatenation previously used the re-export edge's fixed
callandasi_safemetadata when resolving the final binding. This discarded the consuming import's context and could render a CommonJS default call asgetter.a(...)instead ofgetter()(...), changing the function'sthisvalue.After this fix, enabling or disabling
experiments.fasterModuleConcatenationproduces byte-for-byte identical output across all five projects inrstackjs/build-tools-performance(react-1k,react-5k,react-10k,popular-libs, andui-components).Related links
Validation
pnpm run build:binding:devpnpm run test:unit(9208 passed, 4 skipped)cargo fmt --all --checkrstackjs/build-tools-performanceprojects; the full output tree is byte-for-byte identicalChecklist