fix(loader): preserve string BOM across native boundaries by intellild · Pull Request #15632 · web-infra-dev/rspack

intellild · 2026-09-11T03:05:45Z

Motivation

A loader-produced string is transported through the native bridge as a Buffer. Without preserving its original type, the next JavaScript loader treats it as binary input and strips its leading BOM.

For example, in normal execution order producer (JS) -> builtin:test-passthrough-loader -> consumer (JS), returning the string "\uFEFFhello" incorrectly delivers "hello" to the non-raw consumer.

Changes

Populate the existing Rust-to-JavaScript __internal__utf8Hint from the native content variant.
Restore string content before normal JavaScript loader execution, preserving its leading BOM.
Keep the existing BOM stripping behavior for Buffer-to-string conversion and preserve BOM bytes for raw loaders.
Add regression coverage for JS-only and JS/native/JS chains, parallel on/off, string/Buffer outputs, and normal/raw consumers.

Validation

Rust/JavaScript build and clippy passed.
BOM regression tests: 17 passed.
Raw/string loader regression tests: 8 passed.
Disabling the JavaScript hint read reproduces BOM loss in the new regression test; restoring it makes the test pass.

by OpenAI Codex

github-actions · 2026-09-11T03:14:32Z

📦 Binary Size-limit

Comparing 9252ebe to chore(ci): enable Corepack for resolver PnP fixtures (#15640) by Jiahan Chen

❌ Size increased by 4.00KB from 68.48MB to 68.49MB (⬆️0.01%)

github-actions · 2026-09-11T03:20:58Z

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary

Project	Total Size	Gzip Size
popular-libs	1.7 MB	523.6 KB
react-10k	5.3 MB	1.3 MB
react-1k	799.1 KB	217.5 KB
react-5k	2.6 MB	662.0 KB
ui-components	4.9 MB	1.4 MB

Generated by Rsdoctor GitHub Action

cloudflare-workers-and-pages · 2026-09-11T03:22:11Z

Deploying rspack with Cloudflare Pages

Latest commit:	`2aff5ee`
Status:	✅ Deploy successful!
Preview URL:	https://41d98317.rspack-v2.pages.dev
Branch Preview URL:	https://codex-loader-utf8-bom.rspack-v2.pages.dev

View logs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc1bf2701b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-11T03:23:57Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-12T00:14:05.519690Z	`9252ebe`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

codspeed · 2026-09-11T03:46:38Z

Merging this PR will not alter performance

✅ 50 untouched benchmarks
⏩ 47 skipped benchmarks¹

_{Comparing codex/loader-utf8-bom (9252ebe) with main (c1e4c9f)}

47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

intellild · 2026-09-11T06:58:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb06c7ff3d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be9ff94dfc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

intellild · 2026-09-11T10:58:14Z

@codex review

chatgpt-codex-connector · 2026-09-11T11:01:04Z

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 4bb7cfebdc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

intellild force-pushed the codex/loader-utf8-bom branch from 72fab19 to dc1bf27 Compare September 11, 2026 03:13

intellild changed the base branch from codex/loader-metadata to main September 11, 2026 03:14

intellild marked this pull request as ready for review September 11, 2026 03:19

intellild requested a review from hardfist as a code owner September 11, 2026 03:19

chatgpt-codex-connector Bot reviewed Sep 11, 2026

View reviewed changes

Comment thread crates/rspack_binding_api/src/plugins/js_loader/context.rs Outdated

chatgpt-codex-connector Bot reviewed Sep 11, 2026

View reviewed changes

Comment thread packages/rspack/src/loader-runner/index.ts Outdated

intellild requested review from SyMind and ahabhgk September 11, 2026 08:20

chatgpt-codex-connector Bot reviewed Sep 11, 2026

View reviewed changes

Comment thread crates/rspack_binding_api/src/plugins/js_loader/context.rs

intellild added 6 commits September 12, 2026 08:11

fix(loader): preserve string BOM across native boundaries

136fa4b

fix(loader): preserve UTF-8 hint for pitch results

47b99e2

fix(loader): distinguish content types in cache keys

47688a8

refactor(loader): preserve content types across native boundaries

4d7a08a

fix(loader): preserve content types during source map extraction

5b1431c

test(loader): isolate loader cache matrix outputs

9252ebe

intellild force-pushed the codex/loader-utf8-bom branch from 5e78635 to 9252ebe Compare September 12, 2026 00:11

SyMind approved these changes Sep 14, 2026

View reviewed changes

SyMind merged commit df236e5 into main Sep 14, 2026
46 checks passed

SyMind deleted the codex/loader-utf8-bom branch September 14, 2026 02:23

Navigation Menu

Uh oh!

fix(loader): preserve string BOM across native boundaries - #15632

fix(loader): preserve string BOM across native boundaries#15632
SyMind merged 6 commits into
mainfrom
codex/loader-utf8-bom

intellild commented Sep 11, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 11, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 11, 2026 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages Bot commented Sep 11, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Sep 11, 2026 •

edited

Loading

Uh oh!

codspeed Bot commented Sep 11, 2026 •

edited

Loading

Uh oh!

intellild commented Sep 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

intellild commented Sep 11, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

intellild commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Validation

Uh oh!

github-actions Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Binary Size-limit

Uh oh!

github-actions Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rsdoctor Bundle Diff Analysis

Uh oh!

cloudflare-workers-and-pages Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rspack with Cloudflare Pages

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

codspeed Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

intellild commented Sep 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

intellild commented Sep 11, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

intellild commented Sep 11, 2026 •

edited

Loading

github-actions Bot commented Sep 11, 2026 •

edited

Loading

github-actions Bot commented Sep 11, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Sep 11, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 11, 2026 •

edited

Loading

codspeed Bot commented Sep 11, 2026 •

edited

Loading