Skip to content

chore(deps): manage Rstack versions with pnpm catalog - #1855

Merged
9aoy merged 2 commits into
mainfrom
9aoy/chore-pnpm-catalog
Sep 17, 2026
Merged

9aoy merged 2 commits into
mainfrom
9aoy/chore-pnpm-catalog

Conversation

@9aoy

@9aoy 9aoy commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Rsbuild, Rslib, and Rspack dependency versions are repeated across workspace packages, examples, and e2e fixtures, which makes coordinated upgrades harder to review and maintain.

Changes

  • define the shared @rsbuild/*, @rslib/*, and @rspack/* versions in the default pnpm catalog
  • replace workspace dependency and devDependency versions with catalog: references
  • preserve adapter peer dependency ranges because they describe consumer compatibility rather than the repository's installed versions
  • regenerate the lockfile and verify frozen installation, resolved versions, formatting, type checking, package builds, and the published @rstest/core dependency range

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-09-16T09:45:29.872600Z dfb8e02 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rstest with  Cloudflare Pages  Cloudflare Pages

Latest commit: dfb8e02
Status: ✅  Deploy successful!
Preview URL: https://1a983d35.rstest.pages.dev
Branch Preview URL: https://9aoy-chore-pnpm-catalog.rstest.pages.dev

View logs

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

Rsdoctor Bundle Diff Analysis

Found 13 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
adapter-rsbuild 6.1 KB 0
adapter-rslib 51.1 KB 0
browser 1.1 MB 0
adapter-rspack 12.4 KB 0
browser-react 6.4 KB 0
coverage-istanbul 20.1 KB 0
coverage-v8 82.2 KB 0
playwright 53.0 KB 0
browser/client 79.6 KB 0
core/browser 645.2 KB 0
core/main 2.0 MB 0
vscode/extension 1.3 MB 0
vscode/worker 18.4 KB 0

Generated by Rsdoctor GitHub Action

# Conflicts:
#	e2e/package.json
#	packages/adapter-rsbuild/package.json
#	packages/adapter-rslib/package.json
#	packages/adapter-rspack/package.json
#	packages/browser-react/package.json
#	packages/browser/package.json
#	packages/core/package.json
#	packages/coverage-istanbul/package.json
#	packages/coverage-v8/package.json
#	packages/playwright/package.json
#	packages/vscode/package.json
#	pnpm-lock.yaml
@9aoy
9aoy requested a review from Timeless0911 September 16, 2026 12:31
@9aoy
9aoy merged commit de9d6c4 into main Sep 17, 2026
10 checks passed
@9aoy
9aoy deleted the 9aoy/chore-pnpm-catalog branch September 17, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant