feat(core): show previous errors for retried tests - #1862
Merged
Merged
Conversation
Rsdoctor Bundle Diff AnalysisFound 13 projects in monorepo, 1 project with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 core/mainPath:
📦 Download Diff Report: core/main Bundle Diff Generated by Rsdoctor GitHub Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a test passed after retry, the default reporter only showed
(retry xN)and omitted the error from the failed attempt, making flaky failures harder to diagnose.Changes
Show a concise
Previous failure:message for retry errors on tests that ultimately pass. Final failures keep their existing error output. Add an end-to-end regression assertion for the CLI output.Example output:
For Rstest's CI e2e runs, increase the GitHub Actions summary field limit to preserve more of the previous failure log.
Validated with:
./node_modules/.bin/rslib build../node_modules/.bin/rstest run expect/test/soft.test.ts./node_modules/.bin/rstest packages/core/tests/reporter/utils.test.tsThe repository pre-commit/pre-push hooks were skipped because the local global
core.hooksPathcauses the pnpm prepare step to fail before checks run.