Skip to content

feat(core): show previous errors for retried tests - #1862

Merged
9aoy merged 2 commits into
mainfrom
9aoy/fix-retry-error-output
Sep 18, 2026
Merged

9aoy merged 2 commits into
mainfrom
9aoy/fix-retry-error-output

Conversation

@9aoy

@9aoy 9aoy commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Motivation

When a test passed after retry, the default reporter only showed (retry xN) and omitted the error from the failed attempt, making flaky failures harder to diagnose.

Changes

Show a concise Previous failure: message for retry errors on tests that ultimately pass. Final failures keep their existing error output. Add an end-to-end regression assertion for the CLI output.

Example output:

✓ flaky test (retry x1)
  Previous failure: Error: expected 1 to be 2

For Rstest's CI e2e runs, increase the GitHub Actions summary field limit to preserve more of the previous failure log.

Validated with:

  • ./node_modules/.bin/rslib build
  • ../node_modules/.bin/rstest run expect/test/soft.test.ts
  • ./node_modules/.bin/rstest packages/core/tests/reporter/utils.test.ts
  • Prettier check

The repository pre-commit/pre-push hooks were skipped because the local global core.hooksPath causes the pnpm prepare step to fail before checks run.

@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown

Rsdoctor Bundle Diff Analysis

Found 13 projects in monorepo, 1 project with changes.

📊 Quick Summary
Project Total Size Change
adapter-rsbuild 6.1 KB 0
adapter-rslib 51.1 KB 0
adapter-rspack 12.4 KB 0
browser 1.1 MB 0
browser-react 6.4 KB 0
coverage-istanbul 20.1 KB 0
coverage-v8 82.2 KB 0
playwright 53.8 KB 0
browser/client 79.6 KB 0
core/browser 645.2 KB 0
core/main 2.0 MB +183.0 B (0.0%)
vscode/extension 1.3 MB 0
vscode/worker 18.4 KB 0
📋 Detailed Reports (Click to expand)

📁 core/main

Path: packages/core/.rsdoctor/main/rsdoctor-data.json

📌 Baseline Commit: a915d80903 | PR: #1859

Metric Current Baseline Change
📊 Total Size 2.0 MB 2.0 MB +183.0 B (0.0%)
📄 JavaScript 1.6 MB 1.6 MB +183.0 B (0.0%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 440.3 KB 440.3 KB 0

📦 Download Diff Report: core/main Bundle Diff

Generated by Rsdoctor GitHub Action

@9aoy
9aoy merged commit a2ee78b into main Sep 18, 2026
10 checks passed
@9aoy
9aoy deleted the 9aoy/fix-retry-error-output branch September 18, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant