You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Async leak detection can sample Rstest's own fork-worker process.send()WRITEWRAP before the IPC write has completed, causing a false positive in otherwise clean tests. The reported zlib failure was this worker IPC race; the zlib stream itself is already covered by the existing ZLIB handling.
Changes
track outstanding local process.send() callbacks inside ForksChannel
drain pending RPC writes after the file run and before async leak sampling
keep runner hooks and RPC responses asynchronous; only the local IPC write completion is awaited
settle pending writes when the IPC channel disconnects, while thread workers remain a no-op
keep WRITEWRAP detectable so user-created IPC leaks are not globally hidden
add unit coverage for write draining and disconnect behavior
⚠️Note: The latest commit (a2ee78bb13) does not have baseline artifacts. Using commit bbefea9a38 for baseline comparison instead. If this seems incorrect, please wait a few minutes and try rerunning the workflow.
Found 13 projects in monorepo, 1 project with changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Async leak detection can sample Rstest's own fork-worker
process.send()WRITEWRAPbefore the IPC write has completed, causing a false positive in otherwise clean tests. The reported zlib failure was this worker IPC race; the zlib stream itself is already covered by the existingZLIBhandling.Changes
process.send()callbacks insideForksChannelWRITEWRAPdetectable so user-created IPC leaks are not globally hiddenValidation
pnpm check-unused