[geolocation] Test that cached positions are only reused for a matching accuracyMode - #62571
Open
marcoscaceres wants to merge 1 commit into
Open
Conversation
reillyeon
approved these changes
Sep 10, 2026
7 tasks
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The tests correctly exercise both accuracy-mode transitions and robustly distinguish cached from newly acquired positions.
Pull request overview
Adds Web Platform Tests ensuring geolocation cache entries are reused only when accuracyMode matches.
Changes:
- Tests approximate-to-precise and precise-to-approximate requests.
- Uses timestamps to reliably detect cache reuse despite coordinate coarsening.
File summaries
| File | Description |
|---|---|
geolocation/getCurrentPosition-accuracyMode-cache.https.html |
Adds two cache-matching tests for accuracyMode. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds coverage for the accuracyMode cache-matching rule from w3c/geolocation#233, which says a cached position may only be reused when its recorded accuracyMode equals the one now being requested. Nothing in the suite tests it today, in either direction.
Both subtests move the emulated position between the two requests and compare timestamps rather than coordinates, because a reused precise position that gets coarsened on delivery also differs from the one that was cached, so comparing coordinates would pass on the bug being tested. A reused cached position keeps its original timestamp, which holds however much an implementation coarsens.