Bound XML encoding sniffing to the declaration - #12967
Merged
Merged
Conversation
Stop looking for "encoding" at the first > byte when sniffing an XML declaration in text/html. This prevents text after the declaration from selecting the document's encoding, matching Chromium, Gecko, and WebKit. Fixes #6939. Co-Authored-By: codex <codex@openai.com>
annevk
approved these changes
Sep 21, 2026
annevk
left a comment
Member
There was a problem hiding this comment.
Nice catch.
I wondered if encoding="blah > blah" was also problematic, but it seems that in such a case we will always return failure so that is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop looking for "encoding" at the first > byte when sniffing an XML declaration in text/html. This prevents text after the declaration from selecting the document's encoding, matching Chromium, Gecko, and WebKit.
Fixes #6939.
gt-between-xml-and-encoding.htmandgt-between-xml-and-encoding-trail.htm. Both cases and two valid-declaration controls pass in Chromium, Firefox, and WebKit.(See WHATWG Working Mode: Changes for more details.)