You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to the document, we have to add those lines if we’re not using the Docker version of the app. But we can add those lines in the main code. That way, if the env var is set, it will use the config file, otherwise, nothing changes.
I tested this in a non-Docker install and found one important edge case.
Using parse_ini_file with the default scanner can fail on common LDAP-style values in luminary.conf, especially DN values such as:
cn=admin,dc=example,dc=com
In that mode, the parser may throw syntax errors or mis-parse values unless users manually quote many fields. In practice, this makes the documented configuration fragile.
Suggestion:
Please consider using INI_SCANNER_RAW when loading CONFIG_FILE, for example:
parse_ini_file($config_file, false, INI_SCANNER_RAW)
Why this helps:
It preserves values exactly as written in luminary.conf
It avoids breakage for unquoted LDAP DN strings containing equals signs
It is compatible with current code, since booleans are already normalized later via string checks
This would make the non-Docker docs and real-world configs much more reliable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the document, we have to add those lines if we’re not using the Docker version of the app. But we can add those lines in the main code. That way, if the env var is set, it will use the config file, otherwise, nothing changes.