Add deferred resource commands - #357
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Introduces a command-based API for deferred resource operations for adding, removing, and aliasing resources.
Solution
Resource changes are now represented as commands and queued through the world's existing
CommandQueue. The operations are applied when the command execution system processes the queue.Changes Made
The following changes were introduced:
AddResourceCommandto add a resource.RemoveResourceCommandto remove a resource.SetResourceAliasCommandto assign a resource alias.ResourceCommandsas a higher-level API for queuing the three operations.Why This Approach
This solution was chosen because:
Showcase
Before
Resource mutations had no dedicated command API for queuing resource additions, removals, or aliases.
After
Resource operations can be queued through
ResourceCommands:The corresponding operations are then applied when the command queue is executed.
Migration Guide
No migration required.
Checklist