Extract commands into a dedicated package - #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Introduces a dedicated
@wimaengine/commandspackage for high-level engine commands and moves command execution out of@wimaengine/core.Solution
The command architecture is split into three responsibilities:
@wimaengine/commandprovides the command infrastructure, includingCommandQueueand command execution.@wimaengine/commandsprovides high-level commands and APIs such asEntityCommandsandResourceCommands.@wimaengine/coreretains core engine functionality without depending on the command package.Command execution is now registered by
CommandsPluginduring bothStartupandUpdate, in theCoreSystems.Endgroup.Why This Approach
This solution was chosen because:
@wimaengine/core, reducing the responsibility of the core package.@wimaengine/commandsinstead of importing them from@wimaengine/core.Showcase
Before
High-level commands and command execution were part of
@wimaengine/core:Command execution was also registered by
CorePlugin.After
High-level commands are provided by the dedicated commands package:
Command execution is provided by
@wimaengine/commandand registered throughCommandsPluginMigration Guide
No migration is required.
Checklist