Skip to content

Replace internal math implementation with Hisabati - #360

Merged
waynemwashuma merged 3 commits into
wimaengine:devfrom
waynemwashuma:move-math-lib
Aug 18, 2026
Merged

Replace internal math implementation with Hisabati#360
waynemwashuma merged 3 commits into
wimaengine:devfrom
waynemwashuma:move-math-lib

Conversation

@waynemwashuma

@waynemwashuma waynemwashuma commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Objective

Refactors @wimaengine/math to use the standalone hisabati package as its underlying math implementation, reducing duplicated code and centralizing maintenance.

Solution

Changes Made

The following changes were introduced:

  • Added hisabati as a dependency of @wimaengine/math and reexport its API.
  • Removed tests belonging to the extracted math implementation.

Why This Approach

This solution was chosen because:

  • It establishes Hisabati as the single source of truth for the shared math primitives.
  • It reduces code duplication between Wima Engine and Hisabati.
  • It allows the math implementation and its tests to be maintained independently.
  • Re-exporting Hisabati from @wimaengine/math preserves the engine-facing public import path.

Showcase

N/A

Migration Guide

No migration required.

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@waynemwashuma waynemwashuma self-assigned this Aug 18, 2026
@waynemwashuma
waynemwashuma merged commit 963c8d5 into wimaengine:dev Aug 18, 2026
7 checks passed
@waynemwashuma
waynemwashuma deleted the move-math-lib branch August 18, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant