Skip to content

fix: preserve embedded packs across dependency installs#469

Open
wolfy-j wants to merge 1 commit into
mainfrom
fix/preserve-unrelated-embedded-packs
Open

fix: preserve embedded packs across dependency installs#469
wolfy-j wants to merge 1 commit into
mainfrom
fix/preserve-unrelated-embedded-packs

Conversation

@wolfy-j

@wolfy-j wolfy-j commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • limit obsolete embedded-pack cleanup to modules controlled by the active dependency operation
  • preserve the root application and unrelated module filesystems during live installs
  • add a file-backed regression test covering an application pack while installing CRM

Root cause

Dependency expansion resolved only the active root graph, but embedded-pack cleanup treated every installed module absent from that partial graph as removed. The registry entries and HTTP mounts remained live while their backing pack handles were closed, producing HTTP 200 responses with truncated or empty bodies.

Verification

  • go test ./boot/deps/hub
  • go test -race ./boot/deps/hub
  • built local Linux binary with make build-wippy-local
  • started kickside/kickside@0.1.63 in an empty folder
  • installed spiralscout/crm@0.1.18 and spiralscout/stat-analysis@0.1.4 live
  • verified root app, Keeper, Agents, and Knowledge response bodies remained byte-for-byte unchanged after both installs
  • verified CRM and Statistical Analysis UI/API routes and all 14 migrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant