Skip to content

feat: recycle bin - allow viewers access and introduce open action for all users - WPB-26889#4969

Open
jullianm wants to merge 11 commits into
developfrom
feat/viewers-recycle-bin
Open

feat: recycle bin - allow viewers access and introduce open action for all users - WPB-26889#4969
jullianm wants to merge 11 commits into
developfrom
feat/viewers-recycle-bin

Conversation

@jullianm

@jullianm jullianm commented Jul 7, 2026

Copy link
Copy Markdown
Contributor
TaskWPB-26889 [iOS] Allow viewers to open recycle bin

Issue

This PR allows guests ("viewers") to open the recycle bin in the Shared Drive (all other actions are hidden).
In addition, it also introduces the "Open" action on files in the recycle bin and updates a copy.

Testing

  • Be a guest on a conv
  • open shared drive
  • tap on context menu action on the top right
  • observe that only one action is available ("Open recycle bin")
  • worth verifying that non-guests (editors) have all actions available here ("Create folder", "Create file", "Open recycle bin")
  • in the recycle bin, for both guests and non-guests, a new action "Open" should be available on files.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm
jullianm requested a review from a team July 7, 2026 09:51
@jullianm
jullianm requested review from KaterinaWire and acv-w and removed request for a team July 7, 2026 09:51
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 249 tests   2 222 ✅  4m 30s ⏱️
  366 suites     27 💤
    2 files        0 ❌

Results for commit df8f217.

♻️ This comment has been updated with latest results.

Summary: workflow run #29076087147
Allure report (download zip): html-report-31816-feat_viewers-recycle-bin

@datadog-wireapp

Copy link
Copy Markdown

Tests

⚠️ Warnings

🧪 1 Test failed

    testGroup_guestsAllowed_withDriveEnabled() from Wire-iOS-Tests.GroupConversationHeaderViewSnapshotTests

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2626615 | Docs | Give us feedback!

@jullianm
jullianm requested review from David-Henner and caldrian and removed request for KaterinaWire July 8, 2026 15:02
@sonarqubecloud

Copy link
Copy Markdown

@jullianm
jullianm removed the request for review from David-Henner July 10, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants