Skip to content

fix: Gov pipeline - WPB-26202#4992

Open
netbe wants to merge 7 commits into
developfrom
fix/gov-pipeline
Open

fix: Gov pipeline - WPB-26202#4992
netbe wants to merge 7 commits into
developfrom
fix/gov-pipeline

Conversation

@netbe

@netbe netbe commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator
StoryWPB-26202 [iOS] Create Gov edition build pipleline

Issue

The new Gov workflow does not pass all the required secrets. As a security measure, we need to explicitly pass needed secrets, which was before done via secrets: inherit.

  • Update required secrets in .github/workflows/_reusable_app_release.yml

Testing

  • Trigger run

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copilot AI review requested due to automatic review settings July 9, 2026 12:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the GitHub Actions Gov release workflow to explicitly pass the secrets required by the reusable app release workflow (replacing prior secrets: inherit behavior), and relaxes several reusable-workflow secrets from required → optional to support more targeted secret passing.

Changes:

  • Updated gov_app_release.yml to explicitly pass all secrets needed by _reusable_app_release.yml and wire notify_secret to WIRE_IOS_BUILD_WEBHOOK.
  • Updated _reusable_app_release.yml to mark multiple previously-required secrets as optional and added WIRE_IOS_BUILD_WEBHOOK as an optional secret for webhook notifications.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/gov_app_release.yml Switches Gov release to explicit secret passing and sets notify_secret for webhook notifications.
.github/workflows/_reusable_app_release.yml Updates the reusable workflow’s workflow_call.secrets contract to reduce required secrets and include the webhook secret.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 54 to 58
C1_S3_SUBFOLDER_RESTRICTED:
required: true
required: false
C1_S3_SUBFOLDER_PRODUCTION:
required: true
required: false
C3_S3_SUBFOLDER_RESTRICTED:
Comment on lines +76 to +77
WIRE_IOS_BUILD_WEBHOOK:
required: false
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 3f5d2b9.

Summary: workflow run #29017556224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants