UserStore: Add migration logic and migration interpreter - #5324
Merged
Conversation
zebot
added
the
ok-to-test
akshaymankar
force-pushed
the
user-pg-migration-code
branch
from
July 9, 2026 12:35
3e94d0b to
4dcb50c
Compare
akshaymankar
force-pushed
the
user-pg-migration-code
branch
6 times, most recently
from
August 3, 2026 09:25
c109be7 to
acf0807
Compare
akshaymankar
force-pushed
the
user-pg-migration-code
branch
2 times, most recently
from
August 4, 2026 15:05
51dd43c to
1f3a077
Compare
blackheaven
requested changes
Aug 4, 2026
blackheaven
requested changes
Aug 4, 2026
akshaymankar
force-pushed
the
user-pg-migration-code
branch
5 times, most recently
from
August 25, 2026 14:04
dda9c2d to
d86bc83
Compare
akshaymankar
changed the base branch from
develop
to
remove-handle-from-new-stored-user
August 25, 2026 14:27
akshaymankar
marked this pull request as ready for review
August 25, 2026 14:37
blackheaven
approved these changes
Aug 25, 2026
|
|
||
| migration :: Migration | ||
| migration = | ||
| Migration 94 "reduce user gc_grace_period" $ do |
Contributor
There was a problem hiding this comment.
Do we have a changelog entry for this?
Member
Author
There was a problem hiding this comment.
No, but we also don't have an entry for other tables we did this for.
akshaymankar
force-pushed
the
user-pg-migration-code
branch
from
August 26, 2026 07:58
d86bc83 to
f9aab14
Compare
…ontinue to exist in later phases
Using `runAppropriateInterpreter` queries PG twice if the user exists in PG
…ra and PG by different users
When using `State` sometimes the error count is not correct.
These can happen due to race in the migration interpreter. The user who gets it in postgresql first, wins.
Also refactor integration tests for clarity.
akshaymankar
force-pushed
the
user-pg-migration-code
branch
from
August 31, 2026 12:28
c203ed7 to
c62cffd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d