WPB-22954: migrate mls-commit-locks to PostGreSQL - #5415
Open
blackheaven wants to merge 1 commit into
Open
Conversation
Migrate the MLS commit-lock store (galley) from Cassandra to PostgreSQL using the dual-write + background-worker pattern, following the CodeStore recipe. The Postgres acquire replicates Cassandra's IF NOT EXISTS USING TTL via INSERT ... ON CONFLICT DO UPDATE WHERE expires_at < now() RETURNING, honoring both CAS mutual exclusion and TTL expiry (a pure DO NOTHING would leave an expired lock blocking its (group_id, epoch) forever, since Postgres has no TTL reaper). Adds Postgres/DualWrite/Migration interpreters, a migration flag + metrics, helm/config/docs wiring, schema migration, and an integration test.
zebot
added
the
ok-to-test
akshaymankar
left a comment
akshaymankar
left a comment
Member
There was a problem hiding this comment.
Why do we need to migrate these locks? Can we not just use some pg advisory locks instead of creating a table?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-22954
Checklist
changelog.d