WPB-28422 reconcile stale local memberships for deleted remote conversations - #5504
Open
battermann wants to merge 3 commits into
Conversation
battermann
marked this pull request as ready for review
September 1, 2026 14:13
zebot
added
the
ok-to-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces reconciliation logic to clean up stale local membership records when a remote (federated) conversation is definitively absent from the owning backend’s successful response, and adds integration coverage for this behavior.
Changes:
- Reconcile (delete) stale local memberships when a remote “get conversations” call succeeds but omits locally-tracked remote conversation IDs.
- Add integration tests that validate reconciliation behavior (including idempotency) and ensure memberships are preserved on federation failures.
- Update an existing integration test to tolerate “no-conversation” results for a one-to-one conversation after remote user deletion.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| libs/wire-subsystems/src/Wire/ConversationSubsystem/Query.hs | Adds reconciliation side-effect when remote conversations are missing from a successful federated response. |
| integration/test/Test/Conversation.hs | Adds integration tests for stale membership reconciliation and adjusts expectations for one-to-one conversation retrieval after remote user deletion. |
| changelog.d/6-federation/WPB-28422 | Documents the new stale-membership cleanup behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
battermann
force-pushed
the
WPB-28422-backend-reconcile-stale-local-memberships-for-deleted-remote-conversations
branch
from
September 1, 2026 14:31
256eb56 to
0caac72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-28422
Checklist
changelog.d