wolfIP NXP QorIQ FMan port (also big endian fix for ee16/ee32)#136
Open
dgarske wants to merge 6 commits into
Open
wolfIP NXP QorIQ FMan port (also big endian fix for ee16/ee32)#136dgarske wants to merge 6 commits into
dgarske wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new NXP QorIQ DPAA1 FMan (mEMAC + dedicated MDIO) Ethernet port for wolfIP and updates core endian-conversion helpers so wolfIP works correctly on big-endian hosts (e.g., PowerPC e5500/e6500).
Changes:
- Fix
ee16/ee32to be endian-aware (no-op on big-endian, swap on little-endian). - Add
src/port/nxp_fman/port: FMan register definitions, board-override parameters, and a polled RX/TX BD-ring driver. - Add port-specific configuration and documentation for building/using the driver.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
wolfip.h |
Makes ee16/ee32 conditional on host endianness (fixes big-endian behavior). |
src/port/nxp_fman/README.md |
Documents the new QorIQ FMan port model, parameters, and build example. |
src/port/nxp_fman/nxp_fman.h |
Adds FMan/mEMAC/MDIO register map and the public driver API. |
src/port/nxp_fman/nxp_fman.c |
Implements the FMan driver (MDIO/PHY, PRAM setup, BD rings, poll/send). |
src/port/nxp_fman/nxp_fman_board.h |
Provides overridable board-specific defaults (CCSRBAR, PHY addr, mode, etc.). |
src/port/nxp_fman/config.h |
Adds port-specific wolfIP configuration defaults (MTU, DHCP, buffers, etc.). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mEMAC/MDIO + PHY (SGMII/RGMII) + FMan independent-mode RX/TX datapath, one driver for the DPAA1 QorIQ parts (T2080 e6500, T1024/T1040 e5500). Hardware- verified on CW VPX3-152 (DTSEC1 SGMII), NAII 68PPC2 (DTSEC3 RGMII) and T1040D4RDB (DTSEC4 RGMII). Includes nxp_fman_phy_read_at() for MDIO bus scan so multi-port boards can identify the cabled PHY. README documents a per-board bring-up matrix and the WOLFIP_SPEED_TEST throughput benchmark.
Comment on lines
+554
to
+556
| phy_addr = nxp_phy_detect(NXP_QE_PHY_ADDR); | ||
| if (phy_addr < 0) | ||
| return 0x100; /* datapath up, PHY not found */ |
Comment on lines
+691
to
+693
| phy_addr = nxp_phy_detect(NXP_FMAN_PHY_ADDR); | ||
| if (phy_addr < 0) | ||
| return 0x100; /* datapath up, PHY not found */ |
Comment on lines
+589
to
+591
| phy_addr = nxp_phy_detect(NXP_ENETC_PHY_ADDR); | ||
| if (phy_addr < 0) | ||
| return 0x100; /* datapath up, PHY not found */ |
Comment on lines
+440
to
+444
| phy_addr = nxp_phy_detect(NXP_ETSEC_PHY_ADDR); | ||
| if (phy_addr < 0) { | ||
| adjust_link(NXP_ETSEC_SPEED, 1); | ||
| return 0x100; /* datapath up, PHY not found */ | ||
| } |
Comment on lines
+163
to
+167
| /* Soft-reset and bring up the selected eTSEC (MAC, BD rings, MDIO, PHY) and | ||
| * populate ll with the MAC address, interface name and poll/send callbacks. | ||
| * Pass mac=NULL for the built-in default. Returns a status word encoding the | ||
| * detected PHY id high byte, link bit and PHY address, or a negative value | ||
| * on hard failure. */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ethernet driver for the NXP QorIQ Frame Manager (FMan) multirate Ethernet MAC (mEMAC) and MDIO, shared across the big-endian PowerPC DPAA1 QorIQ parts: T2080 (e6500), T1024 and T1040 (e5500). One driver serves every board; all board-specific values come from
nxp_fman_board.h.