PPC64 Assembly: ELF V1 headers added. Little-endian asm added.#10871
Conversation
|
Code generated by PR: |
|
Jenkins: retest this please |
SparkiDev
force-pushed
the
ppc64_le_and_elf1_fix
branch
from
810046d to
71ffa4e
Compare
|
Jenkins: retest this please FIPS-ready (aborted) x2 |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10871
Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
ELF V1 headers are need for cross-compiles. PPC64 is big or little endian so assembly code modified to be able to be built for both. Fix wiring of vector AES implementations in aes.c.
SparkiDev
force-pushed
the
ppc64_le_and_elf1_fix
branch
from
71ffa4e to
3f3ebca
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10871
Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
|
Jenkins: retest this please |
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
| Algorithm | C-only | PR-asm | Speedup |
|---|---|---|---|
| AES-128-CBC-enc | 33.0 | 81.9 | 2.49x |
| AES-256-CBC-enc | 24.4 | 59.3 | 2.43x |
| AES-128-CTR | 33.1 | 80.7 | 2.44x |
| AES-128-GCM-enc | 11.7 | 54.4 | 4.66x |
| AES-256-GCM-enc | 10.3 | 43.2 | 4.18x |
| GMAC Table | 18.2 | 171.6 | 9.43x |
| AES-XTS-enc | 24.9 | 74.3 | 2.98x |
| SHA-256 | 55.2 | 67.1 | 1.21x |
| SHA-384 / SHA-512 | 30.2 | 103.6 | 3.44x |
| SHA3-256 | 28.9 | 69.0 | 2.38x |
| HMAC-SHA512 | 29.7 | 101.7 | 3.42x |
4 participants
Description
ELF V1 headers are need for cross-compiles.
PPC64 is big or little endian so assembly code modified to be able to be built for both. Fix wiring of vector AES implementations in aes.c.
Testing
Tested big-/little-endian PPC64 with assembly code.