perf: reuse semantic state for ToolService queries - #423
Merged
Merged
Conversation
Teakowa
enabled auto-merge
September 27, 2026 13:33
Teakowa
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolService. A non-default session lint configuration gets its own cached findings while sharing the same index.wright-benchwith a recorded repeated-query workload over representative Workshop inputs.Measurement
The same benchmark harness measured the original no-reuse path before the cache change and the updated path afterward. Each measurement averages 5 trials; each trial repeats the listed 10 operations 5 times after
CompilerSession::load().loadedServiceincludesToolService::newplus the repeated queries.synthetic/control-flowsynthetic/declarations-rulesreal-world/overpy-cakeThe measured sequence is
rules,symbols,references(symbol:0),usage(symbol:0),cfg(rule:0),findings,persistentObjects,lint,lintRules, andinspect. The report records this workload in thesemantic_queries.workloadfield.Validation
cargo test --locked --workspace --all-targets --all-features— 260 passed.cargo clippy --locked --workspace --all-targets --all-features -- -D warnings— passed.cargo fmt --all -- --check— passed.cargo run --locked -p wright-bench— passed.Closes #356