[CSM Portal] Proxy saved list filters through the BFF by 2003dinijay · Pull Request #1885 · wso2-open-operations/cs-tools

2003dinijay · 2026-09-21T12:01:00Z

Summary

Authenticates /users/me/saved-filter-views (list / save / delete / reorder) on the CSM BFF and forwards to entity-service.
Save is PATCH (same as entity-service and the rest of this BFF), not PUT.
Merge after [Entity-Service] Persist CSM portal list filters #1884 so entity-service has the routes. This PR is only BFF files.

Test plan

Merge or checkout [Entity-Service] Persist CSM portal list filters #1884 first so entity-service has the routes
GET /users/me/saved-filter-views?listKey=cases through the BFF after login returns 200
PATCH then DELETE a named view; BFF status matches entity-service
Unauthenticated request is 401

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

coderabbitai · 2026-09-21T12:01:09Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: wso2-open-operations/cs-tools/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: f02d05ff-30b7-4353-b421-d965c824720d

📥 Commits

Reviewing files that changed from the base of the PR and between 216c067 and 87dfb26.

📒 Files selected for processing (6)

apps/csm-portal/backend/cmd/server/main.go
apps/csm-portal/backend/internal/entity/customer.go
apps/csm-portal/backend/internal/handler/helpers_test.go
apps/csm-portal/backend/internal/handler/users.go
apps/csm-portal/backend/internal/handler/users_test.go
apps/csm-portal/backend/openapi.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

Changes

Saved filter views

Layer / File(s)	Summary
Saved filter view API contract `apps/csm-portal/backend/openapi.yaml`	The OpenAPI specification adds list, save, delete, and reorder endpoints with saved-view schemas and validation constraints.
Authenticated handler flow `apps/csm-portal/backend/internal/handler/users.go`, `apps/csm-portal/backend/cmd/server/main.go`, `apps/csm-portal/backend/internal/handler/helpers_test.go`, `apps/csm-portal/backend/internal/handler/users_test.go`	Authenticated routes validate query parameters or JSON bodies, delegate to the entity client, map upstream errors, and include handler tests and mock support.
Entity service transport `apps/csm-portal/backend/internal/entity/customer.go`	The entity client sends list, save, delete, and reorder requests with the defined paths, query parameters, and request bodies.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant UsersHandler
  participant CustomerEntityClient
  Client->>UsersHandler: Send authenticated saved-filter-view request
  UsersHandler->>UsersHandler: Validate query parameters or JSON body
  UsersHandler->>CustomerEntityClient: Delegate operation
  CustomerEntityClient-->>UsersHandler: Return entity response or error
  UsersHandler-->>Client: Return response or mapped error

Suggested reviewers: rashmika998

Merge Risk: ⚪ Minimal · up to 87dfb

This change adds authenticated saved-filter-view operations through the BFF, including listing, saving, deleting, and reordering. The supplied implementation and tests show the expected validation, authentication, forwarding, and error handling, so it is mergeable.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 5 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	⚠️ Warning	The description explains the BFF proxy changes and lists a test plan, but it omits most required template sections, including purpose, goals, release note, documentation, security checks, test environ…	Complete the repository template. Add the missing sections and provide the required security, testing, documentation, and release information.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The description links the dependent entity-service pull request `#1884`, and the objectives reference related pull request `#1885`.
Out of Scope Changes check	✅ Passed	The changes match the stated objective. They add BFF routes, entity-service proxy methods, tests, and OpenAPI definitions for saved filter views.
Title check	✅ Passed	The title clearly identifies the primary change: proxying saved list filters through the CSM Portal BFF.

Full details: Docstring Coverage

Explanation

Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 5 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description explains the BFF proxy changes and lists a test plan, but it omits most required template sections, including purpose, goals, release note, documentation, security checks, test environment, and learning.

Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Rashmika998 · 2026-09-21T16:59:27Z

@coderabbitai review

coderabbitai · 2026-09-21T16:59:33Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Passthrough GET/PUT/DELETE/reorder on /users/me/saved-filter-views so the webapp never talks to entity-service directly.

Rashmika998 · 2026-09-22T09:36:15Z

 	route("GET /users/me", handler.PermAuthenticated, usersHandler.GetMe)
 	route("PATCH /users/me", handler.PermAuthenticated, usersHandler.PatchMe)
+	route("GET /users/me/saved-filter-views", handler.PermAuthenticated, usersHandler.ListSavedFilterViews)
+	route("PUT /users/me/saved-filter-views", handler.PermAuthenticated, usersHandler.SaveSavedFilterView)


Can't we have a PATCH instead of a PUT in here?

Yes — switched this to PATCH to match the rest of the BFF (and entity-service). Save is now PATCH /users/me/saved-filter-views on the BFF route, the entity client, OpenAPI, and tests.

Copilot AI lite review requested due to automatic review settings September 21, 2026 12:01

Copilot AI reviewed Sep 21, 2026

github-actions Bot added App/CSM Portal Area/Backend Entity Service labels Sep 21, 2026

github-actions Bot assigned 2003dinijay Sep 21, 2026

2003dinijay mentioned this pull request Sep 21, 2026

[CSM Portal] Persist saved list filters instead of localStorage #1886

Open

4 tasks

[CSM Portal] Proxy saved list filters through the BFF.

2134932

Passthrough GET/PUT/DELETE/reorder on /users/me/saved-filter-views so the webapp never talks to entity-service directly.

2003dinijay force-pushed the dinijay/feat/csm-user-filter-bff branch from e7dfec9 to 2134932 Compare September 21, 2026 17:20

Rashmika998 reviewed Sep 22, 2026

View reviewed changes

[CSM Portal] Save named list filters with PATCH instead of PUT.

87dfb26

2003dinijay mentioned this pull request Sep 22, 2026

[Entity-Service] Save named list filters with PATCH #1914

Open

3 tasks

Navigation Menu

[CSM Portal] Proxy saved list filters through the BFF - #1885

[CSM Portal] Proxy saved list filters through the BFF#1885
2003dinijay wants to merge 2 commits into
wso2-open-operations:dev-app-csm-portalfrom
2003dinijay:dinijay/feat/csm-user-filter-bff

2003dinijay commented Sep 21, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai Bot commented Sep 21, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (2 warnings)

Uh oh!

Rashmika998 commented Sep 21, 2026

Uh oh!

coderabbitai Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

Rashmika998 Sep 22, 2026

Uh oh!

2003dinijay Sep 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

2003dinijay commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (2 warnings)

Uh oh!

Rashmika998 commented Sep 21, 2026

Uh oh!

coderabbitai Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rashmika998 Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

2003dinijay Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

2003dinijay commented Sep 21, 2026 •

edited

Loading

coderabbitai Bot commented Sep 21, 2026 •

edited

Loading

coderabbitai Bot commented Sep 21, 2026 •

edited

Loading