Use the cached proton-electron ratio in Ion.emissivity and make it settable - #471
Open
jacobdparker wants to merge 1 commit into
Open
jacobdparker wants to merge 1 commit into
jacobdparker wants to merge 1 commit into
Conversation
…settable `Ion.emissivity` called the module-level `proton_electron_ratio` directly, walking the entire database on every call, instead of using the cached property on the instance. Replace the `cached_property` with a lazily computed property that has a setter, so a ratio computed once with `fiasco.proton_electron_ratio` can be shared between ions with the same temperature. Fixes wtbarnes#470 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #470
Ion.emissivitycalled the module-levelproton_electron_ratiodirectly on every call, walking the entire database each time, instead of using the cached property on the instance. SinceintensityandIonCollection.spectrumgo throughemissivity, a collection of N ions paid for the walk N times.Changes:
Ion.emissivitynow usesself.proton_electron_ratio.Ion.proton_electron_ratiois now a lazily computed property with a setter, in the same style asabundanceandionization_fraction, so a ratio computed once withfiasco.proton_electron_ratiocan be assigned to every ion sharing a temperature array. Setting it does not change_instance_kwargs, so ions created throughnext_ionand friends compute their own as before.emissivityreflects a ratio that was set.Timing with the full database, O V, 61 temperatures, before and after:
emissivity(first call)emissivity(second call)The first call still computes the ratio once; #466 makes that part cheaper. Results are unchanged.
🤖 Generated with Claude Code