fix(audio): replace queue clears with bounded callback buffering - #92
Draft
sunshinewithmoonlight wants to merge 5 commits into
Draft
sunshinewithmoonlight wants to merge 5 commits into
sunshinewithmoonlight wants to merge 5 commits into
Conversation
Owner
|
I currently have a bunch of fixes in flight around something similar, so will only look at this after. I ask that before sending any PRs you please test this on hardware first as well |
sunshinewithmoonlight
force-pushed
the
fix/audio-low-latency-buffer
branch
from
September 13, 2026 15:57
dde507b to
01602d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
AudioManagerrequests 1024 samples, accumulates SDL queued audio,and clears the whole queue above 16000 bytes.
Scope
OrbisWindowBridge and are not part of this PR.
library/chiaki-ngsubmodule is not modified.Follow-up from hardware testing
original buffering change did not resolve.
effective read position.
Tests
underruns, clear/new-session behavior, non-stereo parameters, and concurrent
producer/consumer stress.
make test: 174 passed, 0 failed.Risk and rollback
AudioManager.This client-side change is not claimed to remove the full end-to-end latency by
itself; the sender packet history and pacing fixes are separate.