Bump the vendored engine to f642631, so a run with no log file reports its errors - #223
Merged
Merged
Conversation
…s its errors Engine #1683 counts log events above the opt->log gate. A run now reports its real error count with no log file open, and a panic counts as an error. Android emits -Q whenever the user turns log files off, so those users saw Success over a run that hit errors. The prebump gate ran with the real pre-bump SHA. HTTRACK_VERSIONID stays 3.50.2, src/Makefile.am is unchanged so Android.mk needs no new source, and no command-line option moved. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engine #1683 counts log events above the
opt->loggate, so a run reports its real error count even with no log file open. A panic now counts as an error too.That reaches users here. Android emits
-Qwhenever the user turns log files off, and those users sawSuccess!over a run that hit errors, becausestat_errorsread 0. The pane now shows the count, and a run that wrote nothing readsFailed!.Runs with failed transfers are unaffected, because
INCOMPLETEis weighed ahead of every error-count test.HTTRACK_VERSIONIDstays3.50.2, so theversionNameprefix does not move. No engine source was added, soAndroid.mkneeds nothing.