Add a Max Retry-After field to WebHTTrack - #1757
Merged
Merged
Conversation
#1755 gave the engine --max-retry-after but left every front end without a field for it. Add one to WebHTTrack's Flow control page beside Retries, and carry the value through the winprofile.ini round trip as MaxRetryAfter. The two LANG_ keys land here because lang.def is this repo's. WinHTTrack's COptionTab4::GetTip() hands LANGSEL()'s empty string to a handler that then shows no tooltip, so its own field cannot be labelled until these exist. The row is owned by web alone. Windows and Android gain their letter when each lands the field, the way PauseFiles gained droid in #1331. default_state=none is what keeps an empty box passing no flag, so the engine's own 60 seconds apply. A front end substituting 60 writes a value nobody chose, which is the MaxRate lesson in doc/winprofile-ini.md. Signed-off-by: Xavier Roche <roche@httrack.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
… were off
The first version of test 493 posted the empty box itself, so a session seed of
60 in htsserver.c's initInt[] was overwritten before the check read it back.
That seed is exactly what the PR argues against, so probe a fresh session
first, before anything is posted.
Three more gaps, each proved by a mutant that now reds:
- a grep for the step2.html directive could not tell a live one from a dead
one, so load a real saved project and read the value back instead;
- the tooltip assertion matched the onMouseOver copy, so anchor it on the
title attribute;
- option4.html's ${attr:} escape had no case, so 217 gains the field.
The Danish, Ukrainian, Bulgarian and Romanian tooltips were wrong: a word the
catalog does not use for a header, a verb that cannot take that construction,
a subject that slips from the user to the program, and the only comma-below
diacritics in a file that spells them with cedillas.
Signed-off-by: Xavier Roche <roche@httrack.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
enabled auto-merge (squash)
September 23, 2026 09:42
xroche
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the field on WebHTTrack's Flow control page, the two
LANG_keys in all 30 catalogs, and theMaxRetryAfterrow inwinprofile-keys.tsv. An empty box passes no flag, so the engine's own 60 seconds apply and no front end writes a value nobody chose.