fix(ru): split sentence-final abbreviations before Cyrillic starts - #57
Merged
yisding merged 4 commits intoJun 12, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8af789d6e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
др,ср,англ,рус, etc.) to unconditionally protect their trailing period and therefore merge sentences when the following sentence began with a Cyrillic uppercase token.англ. Moscow) joined while restoring genuine sentence boundaries when the next token is a new Cyrillic sentence.Description
import unicodedataand aSENTENCE_FINAL_ABBREVIATIONSset listing language tags and common abbreviations that may legitimately end a sentence in Russian insidesentencesplit/lang/russian.py._starts_with_cyrillic_upperand changedreplace_period_of_abbrto use a conditional regex replacement that restores a real period when the following non-space character is a Cyrillic uppercase start and otherwise protects the period with the non-boundary placeholder; this preserves the previous protection for Latin-uppercase glosses and lowercase continuations.tests/lang/test_russian.pycovering both split-before-Cyrillic cases (e.g.Это литература и др. Она важна.) and preserved join cases (e.g.Он читал англ. Moscow.).Testing
uv run pytest tests/lang/test_russian.py --color yesand the Russian tests passed.uv run pytest --cov=sentencesplit tests/ --color yesand all tests passed (1703 passed,8 xfailedin the run recorded here).uv run ruff check .anduv run ruff format --check .which succeeded, and performed a manual PoC usingsentencesplit.Segmenter(language='ru')to verify the reported examples split correctly.Codex Task