fix(spacy): preserve positional language argument - #59
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ae5394bba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
name(defaulting language to"en") which broke callers using the legacy positionalSentenceSplitFactory(nlp, "fr")pattern and caused silent mis-segmentation for non-English text.Description
LANGUAGE_CODESimport and_DEFAULT_COMPONENT_NAMEconstant and updateSentenceSplitFactory.__init__to detect when the providednamematches a supported language code and swapname/languageaccordingly (if language == "en" and name != _DEFAULT_COMPONENT_NAME and name in LANGUAGE_CODES: language = name; name = _DEFAULT_COMPONENT_NAME).create_sentencesplit(nlp, name, language)so custom component names and explicitlanguage=keywords remain unchanged.tests/test_spacy_component.pyverifying positionalSentenceSplitFactory(None, "fr")selects French and thatcreate_sentencesplit(None, "custom_sentences", "fr")preserves both name and language.ruffand ensure import ordering.Testing
uv run pytest tests/test_spacy_component.py --color yesand the new spacy-component tests passed (no failures).uv run ruff check .anduv run ruff format --check .which passed after fixing import ordering and formatting issues.uv run pytest tests/test_spacy_component.py tests/lang/test_french.py --color yesand the targeted tests completed successfully (19 passed, 1 warning).Codex Task