fix(kazakh): preserve standard abbreviation handling - #61
Merged
yisding merged 5 commits intoJun 12, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 140fda9ab7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…-kazakh-abbreviation-handling
…-kazakh-abbreviation-handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
AbbreviationReplacer.replace()only applied two single-letter Cyrillic rules and multi-period handling, bypassing the base replacer logic that protects single-periodABBREVIATIONSand restores abbreviation-boundary periods, which caused incorrect sentence splits for entries likeобл.andтех..Description
Rulepatterns withapply_rulesbefore running the shared pipeline viasuper().replace().replace_single_period_abbreviations()to pre-protectABBREVIATIONSentries stored with a single trailing period by stripping the trailing dot and invoking the standardreplace_period_of_abbrhelper for each matching entry.test_kk_single_period_abbreviations_do_not_split_before_numeric_continuationtotests/lang/test_kazakh.pythat asserts single-period Kazakh abbreviations do not produce sentence splits before numeric/parenthesized continuations.Testing
uv run pytest tests/lang/test_kazakh.py --color yesand the Kazakh language tests passed.uv run pytest tests/regression/ tests/test_segmenter.py tests/test_languages.py --color yesand the targeted regression and integration tests passed.uv run pytest --cov=sentencesplit tests/ --color yeswhich completed with the test suite passing (1759 passed, 8 xfailed) and coverage above the required threshold.uv run ruff check .anduv run ruff format --check .and formatting/lint checks passed.Codex Task