ci(bench): set CodSpeed simulation mode (required in action v4) - #80
Merged
Merged
Conversation
The dependabot bump to CodSpeedHQ/action@v4 (#76) made `mode` a required input with no default, so the deterministic instruction-count `benchmarks` job (the only one without an explicit mode) now fails. Set `mode: simulation` — the modern name for v3's default `instrumentation` (now deprecated). The two walltime jobs already pass `mode: walltime`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Merging this PR will not alter performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dependabot bump CodSpeedHQ/action v3 → v4 (#76) made the
modeinput required (no default). The deterministic instruction-countbenchmarksjob was the only one relying on the old implicit default, so it now fails on every run.Fix
Set
mode: simulationon that job — per the v4 action definition,simulationis the modern name for what v3 calledinstrumentation(now deprecated), i.e. the CPU-instruction-count measurement this job already intends. The two walltime jobs already passmode: walltime, so they were unaffected.- name: Run CodSpeed benchmarks uses: CodSpeedHQ/action@v4 with: + mode: simulation run: >- uv run --no-sync --python 3.13 pytest ...One-line change (plus an explanatory comment). YAML validated; all three CodSpeed jobs now pass an explicit
mode.🤖 Generated with Claude Code