Skip to content

ci(bench): set CodSpeed simulation mode (required in action v4) - #80

Merged
yisding merged 1 commit into
mainfrom
ci/codspeed-simulation-mode
Jun 18, 2026
Merged

yisding merged 1 commit into
mainfrom
ci/codspeed-simulation-mode

Conversation

@yisding

@yisding yisding commented Jun 18, 2026

Copy link
Copy Markdown
Owner

Problem

The dependabot bump CodSpeedHQ/action v3 → v4 (#76) made the mode input required (no default). The deterministic instruction-count benchmarks job was the only one relying on the old implicit default, so it now fails on every run.

Fix

Set mode: simulation on that job — per the v4 action definition, simulation is the modern name for what v3 called instrumentation (now deprecated), i.e. the CPU-instruction-count measurement this job already intends. The two walltime jobs already pass mode: walltime, so they were unaffected.

       - name: Run CodSpeed benchmarks
         uses: CodSpeedHQ/action@v4
         with:
+          mode: simulation
           run: >-
             uv run --no-sync --python 3.13 pytest ...

One-line change (plus an explanatory comment). YAML validated; all three CodSpeed jobs now pass an explicit mode.

🤖 Generated with Claude Code

The dependabot bump to CodSpeedHQ/action@v4 (#76) made `mode` a required
input with no default, so the deterministic instruction-count `benchmarks`
job (the only one without an explicit mode) now fails. Set `mode: simulation`
— the modern name for v3's default `instrumentation` (now deprecated). The
two walltime jobs already pass `mode: walltime`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codspeed

codspeed Bot commented Jun 18, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 33 untouched benchmarks


Comparing ci/codspeed-simulation-mode (d5803a7) with main (376d61f)

Open in CodSpeed

@yisding
yisding merged commit eac81d7 into main Jun 18, 2026
13 checks passed
@yisding
yisding deleted the ci/codspeed-simulation-mode branch June 18, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant