Add *escape-fn* variable - #338
SuperCuber wants to merge 2 commits into
Conversation
|
I'd like to see some tests added around this new behavior. |
|
TY for the comments! I'll wait a bit with this while I evaluate whether it 100% suits my usecase. I don't want to bloat the library with something we might potentially never use 🙃 |
|
@seancorfield looks good to me |
|
LGTM. Do you want to write a first draft of docs as part of this PR? |
|
Still waiting for some doc updates in the PR to explain this new feature. |
|
The feature is needed for a major rework in our systems which will happen "eventually" so we don't need it yet and haven't even confirmed that Selmer will be used for it. I don't mind writing some docs and merging this if you don't mind a potentially unused feature in the library 🙃 |
|
Thanks for the update. In light of that, we'll just keep this open as a draft for a few more months, until you decide one way or another. |
3 participants
Closes #337