Allow tags to be multiline. - #345
Merged
Merged
Conversation
Fixes yogthos#331. This needs changes both in the tests and in the actual parser, since the tests duplicate the patterns.
Owner
|
Thanks, looks good to me. @seancorfield any comments? |
Collaborator
|
LGTM. I'm a bit surprised this didn't already work universally since I certainly split tags across multiple lines already, but perhaps I only split the start/end tags and not the arguments for tags? |
Owner
|
Yeah, I'm surprised we haven't ran into this earlier as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #331.
This needs changes both in the tests and in the actual parser, since the tests duplicate the patterns.
@laconiccrafts if you're able to test this in your project it'd be helpful :). Thanls.