Skip to content

Migrate to wasapi 0.23 (major API restructure) #10

Description

@ytchenak

The wasapi crate underwent a major API restructure between 0.16 and 0.23 that the codebase doesn't yet handle. Dependabot PR #8 failed to compile against it.

What changed (from CI errors on #8)

  • wasapi::DeviceCollection::new — removed / renamed
  • wasapi::get_default_device — moved / renamed
  • AudioClient::initialize_client — signature now takes 3 args (was 5)

Scope

Each of these is called in src/audio/devices.rs, src/audio/capture.rs, and src/bin/test_capture.rs. Migration likely needs ~30–80 LoC of changes plus a doc pass in the WASAPI comments.

Why it matters

  • Soundness improvements in the upstream crate
  • Eventually transitive deps will force us off 0.16 anyway

Out of scope for 0.1.0

This is queued for 0.2.0.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions