Make FastJsonHttpLogFormatter honor the JsonMapper's ObjectWriteContext - #2390
Open
nhmarujo wants to merge 3 commits into
Open
Make FastJsonHttpLogFormatter honor the JsonMapper's ObjectWriteContext#2390nhmarujo wants to merge 3 commits into
nhmarujo wants to merge 3 commits into
Conversation
nhmarujo
requested review from
ChristianLohmann,
kasmarian,
lukasniemeier-zalando and
msdousti
as code owners
September 5, 2026 10:05
kasmarian
reviewed
Sep 7, 2026
Comment on lines
-54
to
62
| public FastJsonHttpLogFormatter(final JsonFactory factory, final JsonFieldWriter delegate) { | ||
| this(factory, delegate, false); | ||
| } | ||
|
|
||
| public FastJsonHttpLogFormatter(final JsonFactory factory, final JsonFieldWriter delegate, final boolean validateJsonBody) { | ||
| this.factory = factory; | ||
| this.delegate = delegate; | ||
| this.validateJsonBody = validateJsonBody; | ||
| this.jsonMapper = mapper; | ||
| this.delegate = writer; | ||
| } |
Collaborator
There was a problem hiding this comment.
Is there a way to still preserve the constructors that use JsonFactory for those who'd prefer to use it? I'm trying to think if a breaking change here is necessary.
Contributor
Author
There was a problem hiding this comment.
Good point. I added a commit to reinstate the constructor that takes a JsonFactory.
I didn't add back the constructor with signature public FastJsonHttpLogFormatter(final JsonFactory factory, final JsonFieldWriter delegate, final boolean validateJsonBody) though, as I don't think it made sense even before. validateJsonBody was necessary purely to create DefaultJsonFieldWriter and didn't have any use in this particular constructor.
Please let me know your thoughts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2389