Fix shift + tab not focusing search engine dropdown while on search bar#14155
Open
Zharkan wants to merge 2 commits into
Open
Fix shift + tab not focusing search engine dropdown while on search bar#14155Zharkan wants to merge 2 commits into
Zharkan wants to merge 2 commits into
Conversation
Member
|
I feel like this would be better suited to be submitted to firefox? Would off-load work from us: https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
Contributor
Author
|
This is Zen specific though, upstream Firefox has scotchBonnet.enableOverride enabled by default, so Tab/Shift+Tab navigation to the search engine dropdown already works there. The issue only exists because Zen disables scotchBonnet, which gates that code path. The search bar widget still uses SearchModeSwitcher regardless of scotchBonnet, so we need this patch to wire up the Tab navigation for it on our side, right ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #14126