CI - Unify the Claude workflow and job names - #4307
Merged
Merged
Conversation
All five Claude workflows now use a "Claude: <what it does>" display name and
a "Claude ..." job name, so the Actions list and the PR check list both group
and read the same way. Cross-references inside the prompts were pointing at
names that no longer existed ("QA Review") and now name the real workflows.
No trigger, permission, or step change. Job ids are untouched, so nothing that
depends on them (needs:, workflow_dispatch, gh workflow run) changes.
finnar-bin
approved these changes
Sep 1, 2026
geodem127
approved these changes
Sep 1, 2026
shrunyan
enabled auto-merge (squash)
September 4, 2026 18:57
Contributor
Acceptance Criteria QA — ✅ PASSNo linked issue found — change-only QA.
Suggested Cypress coverageThis PR only edits |
Contributor
Code Review — ✅ No blockers |
Contributor
Adversarial Browser QANo reproducible edge-case failures found on the surfaces this PR changes. Also checked and working correctly
|
finnar-bin
added a commit
that referenced
this pull request
Sep 7, 2026
## What Two model pins, in two commits: | File | Job | Before | After | |---|---|---|---| | `claude-auto-reviewer.yml` | review | `claude-sonnet-4-6` | `claude-sonnet-5` | | `claude-issue-critique.yml` | triage | `claude-opus-4-8` | `claude-sonnet-5` | After this, all six `claude-code-action` invocations in the repo run `claude-sonnet-5`, and no invocation relies on the action's default model. `grep -i opus .github/workflows/` returns nothing. ## Why **auto-reviewer** was the last workflow on `claude-sonnet-4-6`. That pin dates to #4150, the commit that first added a `--model` flag to the file; nothing since bumped it while the other four workflows moved to sonnet-5. **issue-critique triage** was the only job deliberately on Opus. Changed on the Director's instruction. Two comments in that file justified the Opus pin and are updated with it: - the `# claude-opus-4-8 ... do not downgrade` line above `claude_args` is removed — it no longer describes the file; - the `if:` gate rationale above the `triage` job said the HIGH-duplicate skip "avoids wasting an Opus run". The skip still stands on its own merits, so the condition is unchanged and only the cost framing is reworded. `--max-turns 100` and `timeout-minutes: 20` are untouched on both jobs. ## Not verified A model flag only takes effect on the next event that triggers its workflow, so nothing here demonstrates that either job runs green on `claude-sonnet-5`. If a model string is rejected by the pinned action version, it surfaces as a failed job on the first PR (auto-reviewer) or the first opened issue (triage) after merge. Related, not addressed: `claude-auto-reviewer.yml` carries the repo's oldest action pin, `anthropics/claude-code-action@1dc994e` (v1.0.127), against v1.0.184/185 elsewhere. ## Conflicts None with #4307, which edits lines 1-14 and 36-48 of `claude-auto-reviewer.yml`; this touches line 86. #4307 also edits `claude-issue-critique.yml`, at the workflow/job `name:` keys, not `claude_args`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Contributor
Code Review — ✅ No blockers |
Contributor
Coverage ReportOverall Coverage
Changed Files Coverage
|
agalin920
added a commit
that referenced
this pull request
Sep 18, 2026
Conflict in .github/workflows/claude-change-verifier.yml only, from #4307 (Claude workflow/job rename) landing on dev while this branch rewrote the same report template and gate message. Resolved as dev's names over this branch's logic: - Report heading is `## Acceptance Criteria QA` (dev's name), still bare — this branch removed the agent-written `— <PASS|FAIL|INCONCLUSIVE>` suffix because the post step computes the verdict. - The gate's `::error::` keeps this branch's wording (no "or a clear bug"; the agent no longer judges bugs) and dev's comment name. Two unconflicted lines renamed for consistency, because the post step's parser is coupled to the template it completes: the prompt's "leave the `## …` heading exactly as written" instruction, and the python `startswith(...)` / rewrite pair in `Post or update QA comment`. Leaving those at "QA Review" would have left the heading uncompleted and the counts off every comment. Verification: all five Claude workflows parse under js-yaml; prettier clean. The post step was extracted verbatim from the merged YAML and re-run against the same six fixtures as the original commit — 6✅/1❌ → `❌ FAIL — 1 of 7`; 2✅/1 runtime → `✅ PASS — 2/2 …, 1 needs a running app`; all-runtime → PASS "nothing was checkable"; no criteria → gate red; no marker → gate red; and a disobedient report (own verdict marker, heading suffix, prose ✅) normalised to one marker with the prose ✅ uncounted. Merged tree differs from dev in this one file. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names the five Claude workflows for what they do, and makes the Actions list and the PR check list read the same way.
claude-auto-reviewer.ymlClaude: Code Reviewclaude-change-verifier.ymlClaude: Acceptance Criteria QAclaude-issue-critique.ymlClaude: Issue Triageclaude-negative-qa.ymlClaude: Adversarial Browser QAclaude-sentry-handler.ymlClaude: Sentry Triage & Auto-FixTwo names were wrong against behaviour, not just inconsistent:
complexbranch. CI - Automated Sentry Issue Root-Cause Analysis #4231 specifies two processes, and the workflow implements both::509posts an RCA-only comment onverdict == complex,:526opens an auto-fix PR againstdevonverdict == simple.Three prompts also referenced a workflow called
"QA Review", which has never existed under that name; they now name the real sibling workflows. The comment headings each workflow posts are aligned to the same names (## QA Review→## Acceptance Criteria QA,## Negative QA→## Adversarial Browser QA).Scope
No trigger, permission, secret, model, or step-logic change. Job ids are untouched, so
needs:,workflow_dispatch, andgh workflow run claude-negative-qa.ymlall keep working. The HTML markers (<!-- cv-verifier -->,<!-- negative-qa -->,<!-- claude-code-review -->) are untouched, so comment upsert and every downstream grep still match.Verification
YAML.load;prettier --checkclean.name:changes the check-run names on PRs. Ruleset16667349(dev) requires onlyall_tests_passed, so no required check is affected.reviewersubagent — subagents were unavailable this session.