Skip to content

Remove rounded border on top right and top left - #4340

Merged
shrunyan merged 3 commits into
devfrom
fix/3470-global-search-border
Sep 23, 2026
Merged

shrunyan merged 3 commits into
devfrom
fix/3470-global-search-border

Conversation

@finnar-bin

Copy link
Copy Markdown
Contributor

Removed rounded borders on the top right and top left of the global search dropdown
Resolves #3470

Preview

image

@finnar-bin finnar-bin self-assigned this Sep 18, 2026
@finnar-bin finnar-bin added the bug Something isn't working label Sep 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Localization Reviewer — ✅ No blockers

🔴 Blocking

None

🟡 Advisory

None

@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Acceptance Criteria QA — ✅ PASS — 2/2 code-checkable criteria confirmed, 1 needs a running app

Validates #3470: Search: Dropdown - Rounded Borders appearing incorrectly

  1. ✅ Top-left and top-right corners of the search dropdown paper are set to 0 radius
  2. ✅ Bottom corners remain rounded (4px), matching the pre-existing intended design
Not checkable from the code — needs a running app
  • Fix visually resolves the "rounded borders appearing incorrectly" bug in the browser — the change nests the radius override under a .MuiAutocomplete-paper.MuiPaper-rounded selector to win CSS specificity against MUI's default rounded-corner class, which is a plausible root cause, but this can't be confirmed without rendering the component
Suggested Cypress coverage

cypress/e2e/search/search-bar.spec.js has no assertions on dropdown appearance today (its cases cover saved keywords and accelerators). A visual/structural regression test could open the global search dropdown after typing a query, target the results panel via a data-cy selector, and assert computed border-top-left-radius/border-top-right-radius are 0px while the bottom corners are 4px, covering both the "has options" state (border applied on 3 sides) and the empty/no-results state (no border) so the corner styling can't silently regress again.

@github-actions

Copy link
Copy Markdown
Contributor

Code Review — ✅ No blockers

@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Adversarial Browser QA

No reproducible edge-case failures found on the surfaces this PR changes.

Also checked and working correctly
  • GlobalSearch dropdown (src/shell/components/GlobalSearch/index.tsx) with an active results list (query "qa", "Baseline") — computed border-top-left-radius/border-top-right-radius are 0px and bottom corners stay 4px, matching the fix's intent.
  • Same dropdown in its no-results state (query "zzzznonexistentqueryxyz123") and whitespace-only query (" ") — border-radius stays correctly squared on top, rounded on bottom in both cases.
  • Empty-query "Search in..." chip-picker state (Content/Schema/Media/Code/Block shortcuts) — same corner treatment applies correctly.
  • Clicking the native "Clear" (X) button to reset the field from a populated query back to the chip-picker state — reverts cleanly, no leftover stale option rows.
  • Clicking a search result ("NegQA Baseline With Delay") — navigates to the correct content item edit route; the new nested &.MuiAutocomplete-paper.MuiPaper-rounded selector doesn't interfere with option click-through.
  • An item name containing <script>alert(1)</script> in the result list renders as literal escaped text, not executed — pre-existing, unaffected by this change.

@github-actions

Copy link
Copy Markdown
Contributor

Localization Reviewer — ✅ No blockers

🔴 Blocking

None

🟡 Advisory

None

@github-actions

Copy link
Copy Markdown
Contributor

Code Review — ✅ No blockers

@github-actions

Copy link
Copy Markdown
Contributor

Localization Reviewer — ✅ No blockers

🔴 Blocking

None

🟡 Advisory

None

@github-actions

Copy link
Copy Markdown
Contributor

Code Review — ✅ No blockers

@shrunyan
shrunyan enabled auto-merge (squash) September 22, 2026 20:48
@shrunyan
shrunyan merged commit cbe4e63 into dev Sep 23, 2026
27 of 34 checks passed
@shrunyan
shrunyan deleted the fix/3470-global-search-border branch September 23, 2026 04:34
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Overall Coverage

Lines Statements Branches Functions
61.76% 61.38% 55.96% 56.35%

Changed Files Coverage

File Lines Statements Branches Functions
src/shell/components/GlobalSearch/index.tsx 80.52% 80.92% 69.40% 86.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search: Dropdown - Rounded Borders appearing incorrectly

4 participants