Skip to content

fix: updated list of sub-apps contributor role has access - #2528

Open
finnar-bin wants to merge 1 commit into
stagefrom
fix/2525-update-contributor-permissions
Open

finnar-bin wants to merge 1 commit into
stagefrom
fix/2525-update-contributor-permissions

Conversation

@finnar-bin

Copy link
Copy Markdown
Contributor

Description

Updated the list of sub-apps that the Contributor role has access to

Fixes #2525

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots / Screen recording

image

@finnar-bin
finnar-bin requested a review from agalin920 July 24, 2026 04:37
@finnar-bin finnar-bin self-assigned this Jul 24, 2026
@github-actions

Copy link
Copy Markdown

Review Summary

Reviewed the permission change for the Contributor role (31-71cfc74-c0ntr1b0t0r). LGTM — the change is minimal, well-scoped, and correctly limits the Contributor role to Content, Media, and Apps.

Observations

  • Correctness: The updated flags align with issue 🐛 [Bug]: Contributor Custom Role permissions are not represented correctly #2525's intent to restrict Contributor permissions. Only content, media, and apps remain true, which matches the "5 - Contributor" role's low access level (5).
  • Security: This object is used only for the UI display of base permissions inside CreateCustomRoleDialog/EditCustomRoleDialog. Actual authorization is enforced server-side, so this change corrects the displayed permissions but does not alter enforced access. If server-side ACLs still grant Contributors these products, this PR won't change that.
  • Documentation drift (pre-existing, not introduced by this PR): src/components/accounts/users/baseroles.js:44 describes the Contributor as "Access to Content and Media sections." — but apps: true remains enabled here. Consider whether the description should be updated to reflect that Apps is also accessible, or whether apps should also be flipped to false to match the description.
  • Tests: No tests exist for BASE_ROLE_PERMISSIONS; none needed for this change, but a snapshot or table test would help guard future regressions on these permission maps.

No blocking issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: Contributor Custom Role permissions are not represented correctly

1 participant