Skip to content

fix: updated doc links - #2531

Open
finnar-bin wants to merge 1 commit into
stagefrom
fix/2530-update-docs-links
Open

finnar-bin wants to merge 1 commit into
stagefrom
fix/2530-update-docs-links

Conversation

@finnar-bin

Copy link
Copy Markdown
Contributor

Description

Updated dead doc links to point to the new docs

Fixes #2530

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Manual Test
  • Unit Test
  • E2E Test

Screenshots / Screen recording

Please add screenshots or recording if applicable

@github-actions

Copy link
Copy Markdown

Review

Clean, well-scoped fix. All five URL replacements in src/components/accounts/constants/index.js correctly repoint from the retired zesty.org / *-api.zesty.org domains to the new docs.zesty.io documentation. The developerDocs array is consumed by DeveloperDocMenuAccountsNavItem, which reads p.title / p.url, so the shape is unchanged and the menu will render the new links without further code changes.

Code quality

  • Focused change with no drive-by edits — good.
  • Object formatting is consistent with the rest of the file.

Bugs / issues

  • None introduced. The Node SDK, Fetch Wrapper, Status, and Parsley entries were intentionally left untouched, which is correct — they still resolve.

Security

  • No security implications. External anchors in AccountsNavItem don't set rel="noopener noreferrer" or target="_blank", but that's pre-existing behavior across all nav items and out of scope here.

Performance

  • N/A — static constant update.

Optional follow-ups (not blocking)

  • src/components/accounts/ui/menu/DeveloperDocMenu.js lines 40–48 render a Menu block that uses e.label / e.link instead of e.title / e.url. It's dead code (the Menu is never opened — anchorEl is never set), and pre-existing, but worth cleaning up in a future pass.
  • Several JSDoc header comments under src/views/zesty/*.js still reference https://zesty.org/services/... article URLs. Those aren't user-facing and are out of scope for this PR, but the same doc-migration effort may want to sweep them later.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manager UI - Fix outdated documentation link in Instance Manager Settings

2 participants