Return failure status for GL validation errors - #664
Open
thierrygosselin wants to merge 1 commit into
Open
thierrygosselin wants to merge 1 commit into
thierrygosselin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several fatal validation paths in the genotype-likelihood and genotype-calling modules used
exit(0). This reports successful completion to the operating system even when ANGSD has rejected the input or parameters.This change replaces those success-status exits with
EXIT_FAILUREin:abcGL.cpp;abcCallGenotypes.cpp.The diagnostic messages and validation logic are unchanged. Only the process exit status is corrected, so wrappers and downstream workflows can reliably detect failed ANGSD runs.