Validate BCF contig identifiers before writing - #673
Open
thierrygosselin wants to merge 1 commit into
Open
thierrygosselin wants to merge 1 commit into
thierrygosselin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BCF writer looked up each contig with
bcf_hdr_name2id()but did not check whether the lookup succeeded.If the contig is absent from the BCF header, HTSlib receives an invalid record identifier and may fail later with an opaque error or produce unusable output.
This change checks the contig identifier before writing the record and returns a clear failure message when the contig dictionary is inconsistent.
No genotype, allele or likelihood calculations are changed.
Related to #402 and #630.