fix: qualify beta setup, Copilot transport, witness and upgrade safety together - #566
Draft
Pal Lakatos-Toth (pallakatos) wants to merge 34 commits into
Draft
Pal Lakatos-Toth (pallakatos) wants to merge 34 commits into
Pal Lakatos-Toth (pallakatos) wants to merge 34 commits into
Conversation
Expose current-generation controller readiness diagnostics in the catalogue, avoid stale readiness claims, and document namespace-local image pull prerequisites after a clean Helm reinstall. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
Verify constrained root Pod admission against a strict server-side dry-run before protection writes and during restored-root continuity. Preserve reviewed lineage, namespace and ServiceAccount fences and frozen retirement scope. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Serialize device polling with cumulative slowdown and expiry, surface transport and upstream failures, and preflight governed credential storage before consuming authorization. Preserve write-time identity and authority checks and report uncertain persistence honestly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Separate schema-first core and additive Bridge installation from live acceptance, document registry and MCP restore ordering, and retain actual baseline failures without publishing private configuration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
…ests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
…relaxing completion Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
… failure Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
…ew diagnostics Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
…g beta limits Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Reuse the existing root non-BestEffort resource rule without widening root identity or accepting altered/duplicate tolerations. Five regressions fail before fix, including a non-root owner producing the observed identity-error category; 399 targeted tests pass after. Native cause and final acceptance still require exact-head qualification. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
… impact Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
…ut redirects Retain test-only loopback transport and credential write authority while sharing the production endpoint boundary across sign-in and provider operations. Hosted Rust execution and CodeQL qualification remain required. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
…n limits Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Reuse the exact enforcement normalization for boolean-only failure evidence. Preserve original errors and all checks; native projection rejects unknown, duplicate, missing or nonboolean fields. 400 targeted CLI and 15 diagnostic tests pass; native cause remains unproven. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
… setup status Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
…ng fixtures Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Use exact-path coverage for upstream Apache license and scoped attribution rather than relicensing adapted Gadget material. Preserve runtime/chart contracts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
A router self-probe can succeed before the Pod phase is Running. Require bounded Deployment readiness before the single port-forward attempt; retain transport failure classification, redaction, cleanup and all auth/scope assertions. Two regressions fail before, all 12 pass after. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Preserve unqualified, read-only and genuinely root-free operations while requiring supported migration for sealed or in-progress roots. This preflight does not implement the migration protocol tracked in #567. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Skip mutation preflights only for checkOnly while retaining schema, ownership, publication and server render verification. Regression fails before fix; 162 targeted cases pass afterward. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
…cycle Record independent root/witness follow-up closures, exact 57-guard integration and provisional combined validation. Keep root migration, native execution and live target restoration limits explicit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
…losure Preserve native uncertainty, nondefault plugin qualification and exact value-free diagnostic bounds. All assembled source scopes are closed; hosted final-head qualification remains mandatory. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Native evidence showed exact non-root execution was rejected solely by the opt-in label selecting root-only verification. Require the owning ReplicaSet's exact controller Deployment identity before forcing replay; preserve ordinary non-root mismatch refusal and mandatory root admission. Two regressions fail before; 473 targeted cases pass after. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Use fixed localhost fixture URLs with validated loopback DNS routing. Preserve production HTTPS/no-redirect transport and existing tests; add a fixed-URL fixture regression. Fresh hosted execution and CodeQL remain required. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Close the direct Pod-to-Deployment lineage found in review without restoring false root verification for exact non-root consumers. Preserve original failure and zero-write behavior. Direct-owner regression fails before repair; 474 targeted tests pass after. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Preserve failed native and alert-verdict evidence, the repaired direct-root finding, source-only review limits and fresh final-head requirements. Combined local CLI validation passed 736 cases; no native or CodeQL acceptance is inferred. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recover the public-beta setup defects and qualify the requested follow-ups as one coherent candidate:
The current installed cluster remains on public
3bc7ff58; these changes have not been deployed. Target iskars-bridge, notmain.#568 is retained as the original witness review/evidence record; its corrected source is now included here so the final fixes are qualified together rather than against incompatible intermediate bases. It will be closed as superseded only after the combined source is successfully merged.
Current candidate qualification
Current public candidate:
a79b5438feb03b32f11f6d6ac939d685f37d4345.All follow-up source reviews are closed, including the root-selection repair
and its direct-owner safety correction, and the test-only fixed-localhost
fixture routing. The actual native and CodeQL alert verdicts must be established
again on this head; neither is inferred from source review.
Fresh runs: core,
native are in progress.
CodeQL passed all three
analysis jobs, and its separate alert verdict
also passed on this exact head. The remaining alert 833 now reports fixed on
the PR merge ref, with no manual dismissal or configuration suppression.
Bridge passed.
Actual BFF logs confirm all sixteen Copilot tests, including the new
fixed-localhost/pinned-socket network regression, executed successfully.
BFF totals are 284 unit tests plus four and two additional groups.
Repository/source-audit gates,
Dependency Review and
Secret Scanning passed.
Analysis-job success was not substituted for the separate alert verdict.
The final local join passed 736 CLI tests across 23 files, types/build/focused
lint and fifteen native diagnostic tests. All 58 exact Rust registration
guards and the witness parity step remain, including sixteen Copilot tests.
The final native lifecycle and complete core workflow still require acceptance.
No earlier run was cancelled to publish this update.
Retained
e6908eb5qualificationCore CI
completed successfully, including real Kind, chaos and Criterion gates.
Native qualification
failed the observer preview; all three cold-install API lanes passed. The new
diagnostic shows a non-root consumer with all twelve normalized execution
sections matching, yet it was sent through root-only admission verification.
The unconditional Workload Identity opt-in selector is the reproduced defect:
local regressions fail in both same-root-namespace and separate-namespace cases.
A narrow pinned-root selection repair is now in the current candidate.
Independent review caught a direct Pod-to-root-Deployment shortcut in the
initial follow-up; it was repaired and re-reviewed before publication.
The existing verifier still rejects that unsupported lineage, and root WI
admission remains mandatory. This is not yet a successful native outcome.
All three CodeQL analysis jobs
completed successfully, but the separate CodeQL alert verdict
failed with one high cleartext-transmission alert at
copilot_transport.rs:65.The three original alerts (830-832) now report fixed on this PR's merge ref.
The implementation investigation traces the remaining alert to test-only
loopback URL construction rather than a production credential interpolation.
A fixed-localhost URL/socket-routing separation is now independently
source-reviewed and included in the current candidate. It still requires fresh
hosted execution and alert analysis. Successful
analysis jobs are not being substituted for a passing verdict; no alert is waived.
Bridge CI passed all
11 jobs. Actual logs confirm all 15 Copilot and eight witness Rust regressions
executed successfully; BFF totals were 283 unit tests plus four and two further
test groups, with locked Clippy passing. Locked web production image/startup,
the pinned witness image and real guarded add-on Helm lifecycle also passed.
Repository/source-audit gates,
Dependency Review
and Secret Scanning
have passed. This is not a final merge verdict.
All bounded source reviews are now closed, including the final value-free admission diagnostics. Separate audit records disclose exact source ranges, independent AI contexts, findings/repairs, maintainer delegation and execution limits; no broad independent assembly review or second human reviewer is implied.
The initial combined candidate preserved exact implementation slices and 57 regression-registration guards plus parity. Its combined local results were 733 CLI tests across 23 files, CLI types/build/focused lint; 94 web tests, full web types/focused lint; 13 producer, seven chart, three parity, twelve governed-readiness and fifteen native-diagnostic tests, plus Rust formatting. The follow-up expands the CLI evidence to 736 tests and registration to 58 as recorded above. Caches remain provisional and no local Rust execution is claimed.
Fresh final-head core, Bridge, native and CodeQL qualification is required. Earlier runs below are retained evidence, not substitutes for that result. Native diagnosis is still open:
PodTolerationRestrictionis not default-enabled on Kubernetes 1.31, so the QoS reproduction is not asserted as the proven cause of the earlier Kind failure.Review and qualification
Independent, bounded AI source reviews covered the AKS repair, MCP/Copilot contracts and composition, and the later writer-settlement change. Two Copilot review findings were fixed and re-reviewed: uncertain in-flight expiry and nested/unregistered Rust tests. The existing BFF inventory gate now requires both formerly nested tests by exact name.
New audit records disclose actual participants, source bounds, the maintainer's explicit delegation, unresolved deployment limitations and unexecuted checks. They do not imply a second human review or waive technical gates.
Actually executed locally:
Local dependency caches are provisional (YAML 2.9.0 versus locked 2.8.3; Next 16.2.9 versus locked 16.3.3). They are not substitutes for hosted qualification.
Combined-head evidence
On exact
8952689bf571d1334f0b0c6d053fbcd936f1daa5, Bridge CI 34990200325 passed all 11 jobs. All eight Copilot Rust tests actually registered and executed, including both formerly nested cases; BFF Clippy passed. The locked Next 16.3.3 production image compiled and started successfully.Core CI 34990200422 completed successfully, including Kind, chaos and benchmark gates. Native qualification 34990200439 failed at the initial controller preview; the later writer/observer cases did not execute. Its three cold-install API lanes passed. CodeQL separately reported three high cleartext-transmission alerts in Copilot login/provider routes; these are being addressed and are not waived. No repair deployment has occurred.
The investigation confirmed that the Kind fixture inherited Azure Workload Identity opt-in despite installing no Azure identity webhook. Four-file test-harness follow-up
616cbdb1explicitly selects the non-Azure setting and retains only closed admission-stage diagnostics. Production CLI/admission checks, AKS values and chart defaults are unchanged. Two regressions failed before that follow-up; all 18 targeted fixture/diagnostic tests and actual fixture Helm rendering passed afterward.Follow-up candidate
3d1ea2ba996d534c5f3cf19cf9ec477e6be6b736adds only that harness correction and the verified live MCP recovery record. It is published on isolatedqualify/bridge-beta-3d1ea2ba; native qualification 34992902236 failed later, at the private-observer preview with the closedroot-pod-admission-identitydiagnostic. The initial controller preview and intervening lifecycle cases passed. That isolated run preserved the useful old-head core run rather than cancelling it; the PR remained at8952689buntil that core run completed. These are historical outcomes, not final-head qualification.The subsequent HTTPS/no-redirect transport, exact non-root QoS comparison and value-free diagnostic repairs have completed their bounded independent source reviews and are included in the current composition. The QoS change reproduces the same identity-error category with a reviewed non-root Pod; five regressions failed before repair and 399 targeted CLI tests passed afterward. The retained native artifact lacks the full rejected Pod spec, so this is not asserted as the proven native cause or a successful native repair yet.
Verified live MCP recovery
On the unchanged installed public
3bc7ff58, only the original approved, configured managed-MCP pull credential was restored to its correctly claimed namespace, using strict server dry-run and CREATE-only semantics. The existing controller reconciled Playwright to current-generation Ready and discovered 24 tools; its actual Pod is Ready on the pinned image. Parent read-only follow-up independently confirmed those observations and unchanged protected model, alias and cluster namespace identities. No controller/ServiceAccount/MCP spec or manual readiness override was needed. General node image-pull access and the other installation blockers remain separate.After that recovery, a separate explicit operator request removed GPT-OSS through AI Runway to free the H100. Normal provider cleanup removed only the model workloads; the node remained Ready with zero GPU memory use and no compute processes. Local GPT-OSS inference is now intentionally unavailable. This later operation does not change the earlier MCP recovery evidence or constitute deployment of this PR.
Retained earlier-head evidence
a9a35bba: Bridge component run 34983443655 passed, including real BFF and locked web production execution.No earlier-head success qualifies the new combined source.
Explicitly not claimed or included
Merge and matching-source image deployment remain conditional on actual final-head qualification and the separately documented operational prerequisites.