feat: add optional operator-owned datapath witness Helm switch - #568
Closed
Pal Lakatos-Toth (pallakatos) wants to merge 3 commits into
Closed
Pal Lakatos-Toth (pallakatos) wants to merge 3 commits into
Pal Lakatos-Toth (pallakatos) wants to merge 3 commits into
Conversation
… setup status Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
…ng fixtures Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb3654cd-f1e0-445a-8734-430800af1903
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
Collaborator
Author
|
Superseded by the source-reviewed and fully qualified combined repair in #566, merged into kars-bridge as d01d0e2. The corrected witness implementation and tests are included there; this PR and its earlier failed/successful runs remain historical evidence. No live witness enablement, legacy adoption or kernel-coverage claim is made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional operator-owned datapath witness
Merged integration: the corrected witness source through
4337c848landed via the fully qualified #566 as publickars-bridgecommitd01d0e258454f4ed61c6788c7ca3bf07f2fa93ab. This PR is closed as superseded and retains the original witness evidence. Reviewed source is also preserved onreview/bridge-witness-4337c848. No live witness enablement or successful kernel-capture claim is made.Implements the requested easy eBPF witness switch as a separate default-off Helm add-on. Admins get copyable enable/disable commands and truthful installation/evidence status; the BFF does not gain privileged installation authority.
Independent source review and repair
Producer/chart/packaging review closed at
15579b1cdf7adcc7bff34088631299c0a3973e84. Separate BFF/web review found that incomplete beyond-baseline sets could produce contradictory negative evidence. Correctivef5dfe2c647667fb3fa02e4e17d4ba80db9271b9arequires the complete computed set and was independently closed. Shared fixtures exercise the actual producer matching contract, with an explicit CI step.The committed audit records bounded independent-context AI review under the maintainer's existing delegation, not a second human review or a gate waiver.
Qualification
Executed locally: 13 producer tests, seven chart tests, three producer/consumer parity tests, all 54 web tests, full web TypeScript checking, focused lint and Rust formatting. The existing web cache has Next 16.2.9 rather than locked 16.3.3, so it is provisional evidence.
On exact public head
b360441ef38a6232bd52250bfcf90bb0fb94c66c, Bridge CI 34993669330 passed, including locked BFF build/tests/Clippy, the actual producer/consumer parity step, locked web production image and real guarded Helm enable/off/removal in disposable Kind. The pinned witness image built and its provenance checks passed. These do not establish successful kernel capture.That original head did not pass full qualification: copyright coverage rejected four first-party header layouts plus unclassified/scoped upstream licensing files; core CI 34993669274 failed its governed-service port-forward because the selected Pod was not Running; native 34993669340 failed team runtime readiness and observer writer settlement. Packaging and bounded pre-forward rollout-readiness repairs are now independently source-reviewed and included in the combined #566 candidate, not this historical PR head. No failure is waived.
This branch is based on public
kars-bridgeat3bc7ff58, independently of #566. Joining that beta repair must preserve both Copilot registration guards in addition to this branch's 42, and retain the new parity CI step. The additional pending Copilot transport repair raises the eventual union to at least 57 exact registration guards.Explicit limits
No live enablement, legacy adoption, duplicate observer, H100/GPU/node mutation or deployment has occurred. Kernel collection is broader than retained sandbox aggregates. Helm lookup is neither atomic nor namespace-UID-pinned. Reports are partial observations, not enforcement or complete/cryptographic coverage. Successful per-node kernel loading, capture and termination still require separate acceptance.
The public base, installed beta and all required branch protections remain unchanged until final-head qualification and protected merge.