Fix Bedrock vote name collisions - #281
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The resolver checked an online prefixed player (for example,
.Name) before checking whether the exact unprefixed Java identity (Name) was already stored. That allowed an online Bedrock account to absorb an offline Java account's vote. The database fallback also depended on a null check even thoughgetUsercan construct a wrapper for a name that is not stored.The VotingPlugin listener-side safeguard is in VotingPlugin#1538.
Behavior after this change
Nameresolves to an existing exact Java identity, even while.Nameis online..Nameremains the Bedrock identity when the vote arrives explicitly prefixed.Namecan still fall back to.Namewhen no exact Java identity exists.Validation
git diff --checkAI disclosure
Created with assistance from OpenAI Codex.