Skip to content

Preserve validated vote identities - #1538

Merged
BenCodez merged 1 commit into
masterfrom
agent/preserve-validated-vote-identity
Jul 31, 2026
Merged

Preserve validated vote identities#1538
BenCodez merged 1 commit into
masterfrom
agent/preserve-validated-vote-identity

Conversation

@BenCodez

Copy link
Copy Markdown
Owner

Summary

  • treat a successful VotePlayerValidator result as the authoritative player identity
  • avoid running a second Bedrock-name resolution pass that can redirect an exact stored Java name to an online prefixed Bedrock player
  • retain the existing resolver path for invalid-but-allowed unjoined votes
  • include the validation source in debug output

Why this is needed

Validation already checks exact online, cached, and stored identities before prefixed Bedrock fallbacks. The listener then discarded that decision and resolved the normalized name again. During a Java/Bedrock same-name collision, that second pass could select the online prefixed account and award it the Java account's vote.

This is a defensive companion to AdvancedCore#281, which fixes the shared resolver ordering itself.

Behavior after this change

  • Unprefixed votes validated as an exact Java identity stay attached to that Java identity.
  • Explicitly prefixed incoming votes retain their Bedrock identity.
  • Unique Bedrock fallback continues to be decided by validation.
  • AllowUnjoined keeps its previous general-resolution behavior when validation cannot establish an identity.

Validation

  • git diff --check
  • Maven and a JDK were unavailable in the local execution environment, so compilation and test execution are left to GitHub CI.

AI disclosure

Created with assistance from OpenAI Codex.

@BenCodez
BenCodez marked this pull request as ready for review July 31, 2026 22:36
@BenCodez
BenCodez merged commit f70af0a into master Jul 31, 2026
4 checks passed
@BenCodez
BenCodez deleted the agent/preserve-validated-vote-identity branch July 31, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant