Preserve validated vote identities - #1538
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VotePlayerValidatorresult as the authoritative player identityWhy this is needed
Validation already checks exact online, cached, and stored identities before prefixed Bedrock fallbacks. The listener then discarded that decision and resolved the normalized name again. During a Java/Bedrock same-name collision, that second pass could select the online prefixed account and award it the Java account's vote.
This is a defensive companion to AdvancedCore#281, which fixes the shared resolver ordering itself.
Behavior after this change
AllowUnjoinedkeeps its previous general-resolution behavior when validation cannot establish an identity.Validation
git diff --checkAI disclosure
Created with assistance from OpenAI Codex.