Skip to content

Update and create Taamera Libanos records - #2082

Merged
CarstenHoffmannMarburg merged 7 commits into
masterfrom
Update-LIT4717TaammerLi_CH
Sep 17, 2026
Merged

CarstenHoffmannMarburg merged 7 commits into
masterfrom
Update-LIT4717TaammerLi_CH

Conversation

@CarstenHoffmannMarburg

Copy link
Copy Markdown
Contributor

I updated the miracles of Libānos and created new records according to our discussion in BetaMasaheft/Documentation#3387.

I updated the miracles of Libānos and created new records according to our discussion in BetaMasaheft/Documentation#3387.
I updated the miracles of Libānos and created new records according to our discussion in BetaMasaheft/Documentation#3387.
CarstenHoffmannMarburg added a commit to BetaMasaheft/Manuscripts that referenced this pull request Sep 11, 2026
I updated the Taammera Libanos records in BetaMasaheft/Works#2082 and LIT1494Gadlas in BetaMasaheft/Works#2081.

I created new PRS records in BetaMasaheft/Persons#1448.
<revisionDesc>
<change who="MV" when="2017-09-08">Created entity</change>
<change when="2020-02-01" who="ES">updated after MGM-012</change>
<change when="2026-09-03" who="CH">Upated labels and added corresp CAe to edition</change>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All div together with labels must be deleted as per issue.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already restored this relation.

Comment thread 4001-5000/LIT4717TaammerLi.xml Outdated
</listBibl>
<listRelation>
<relation name="ecrm:P129_is_about" active="LIT4717TaammerLi" passive="PRS6298Libanos"/>
<relation name="saws:contains" active="LIT4717TaammerLi" passive="LIT7618MirLib1"/>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the individual miracles should have a "may form part of" relation, this is not needed, as the TM collection in any manuscript may have any of the miracles, not all of them saws:contains means it always includes all parts

@CarstenHoffmannMarburg CarstenHoffmannMarburg Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find a relation of that kind in the list. The relations, which I found are saws:contains, which is for a fix sequence and ecrm:CLP46i_may_form_part_of, which is for the individual record referring to the collection.

So far all miracles have a ecrm:CLP46i_may_form_part_of referring to LIT4717TaammerLi. Therefore it is redundant to have the opposite relation here. We have double notification of each miracle in the list, if we include each miracle here and in the miracle records.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I meant. individual miracles have may form part of relation. There should be no reduntant and misleading saws:contains relations

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial comment implied DELETE ALL WRONG saws:contains RELATIONS

Comment thread 4001-5000/LIT4717TaammerLi.xml
<label>Miracles</label>
</div>
</div>
<listRelation><relation name="ecrm:P129_is_about" active="LIT4717TaammerLi" passive="PRS6298Libanos"></relation></listRelation>

@eu-genia eu-genia Sep 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this relation
<relation name="ecrm:P129_is_about" active="LIT4717TaammerLi" passive="PRS6298Libanos"></relation> should not have been deleted

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already restored it.

@eu-genia eu-genia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, wonderful work!

@CarstenHoffmannMarburg
CarstenHoffmannMarburg merged commit a449f62 into master Sep 17, 2026
2 checks passed
@CarstenHoffmannMarburg
CarstenHoffmannMarburg deleted the Update-LIT4717TaammerLi_CH branch September 17, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants