Fix #114: select the OpenFold query dir by content, not by exclusion - #115
Merged
Conversation
openfold3 0.4.5 writes msas/ into the output dir whenever it generates MSAs (ColabFold server, RNA dummy MSA). The normalizer took the first directory that wasn't raw/ from an UNORDERED iterdir(), so O02 and O04 failed on mango with 'No seed_* directories in .../msas' while the four upload-path cases passed. Only a directory containing seed_* children now qualifies; the error message lists what was found instead. The regression test plants a msas/ distractor that sorts before the query dir, so it reproduces the failure deterministically instead of depending on filesystem order — verified failing on the old code. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DEWo4xvL59PHC1QUvtTV9F
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114.
Production regression from the openfold3 0.4.1→0.4.5 bump in
folding_260821.1: 0.4.5 writesmsas/into the output dir whenever it generates MSAs, andnormalize_openfold_outputpicked its query dir as the first entry of an unorderediterdir()that wasn'traw/. Matrix cases O02 (msa server) and O04 (RNA dummy MSA) failed withNo seed_* directories in .../msas; the four upload-path cases passed because they produce nomsas/dir.The selection is now by content — only directories containing
seed_*children qualify — and the no-match error lists the directories actually found. This also fixes the latent pre-0.4.5 fragility: with two query dirs,query_dirs[0]of an unordered listing was arbitrary; it now takes the sorted first among qualifying dirs.Regression test plants a
msas/distractor that sorts before the query dir, making the reproduction deterministic; verified failing against the old code. 612 passed, 10 skipped.