Skip to content

ci: declare FLAKY_BENCHMARKS_REGEX and document benchmarks CI - #371

Merged
igoragoli merged 5 commits into
mainfrom
augusto/flaky-benchmarks-monitoring-docs
Oct 1, 2026
Merged

igoragoli merged 5 commits into
mainfrom
augusto/flaky-benchmarks-monitoring-docs

Conversation

@igoragoli

@igoragoli igoragoli commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • Declare an empty FLAKY_BENCHMARKS_REGEX in the benchmarks job, linked to Flaky Benchmarks Monitoring.
    • A scenario matching it still runs and reports, but doesn't fail the gate.
  • Add .gitlab/BENCHMARKS.md with the benchmarks CI layout and how to mark a benchmark as flaky.

Motivation

APMSP-3925 Onboard dd-trace-* and nginx-datadog to benchmark stability monitoring

Additional Notes

YAML parses. Runs are unchanged since the declared value is empty.

Jira ticket: APMSP-2893

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pr-commenter

pr-commenter Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-10-01 13:38:17

Comparing candidate commit bf73099 in PR branch augusto/flaky-benchmarks-monitoring-docs with baseline commit df496e9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@igoragoli
igoragoli marked this pull request as ready for review September 29, 2026 09:43
@igoragoli
igoragoli requested review from a team as code owners September 29, 2026 09:43
@igoragoli
igoragoli requested review from Anilm3 and removed request for a team September 29, 2026 09:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T09:44:38.081039Z 29b47bc Draft marked ready
🔒 Security Review ✅ Completed 2026-09-29T09:45:11.591176Z 29b47bc Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1

This comment has been minimized.

Comment thread .gitlab/benchmarks.yml Outdated
Comment thread .gitlab/BENCHMARKS.md
Comment thread .gitlab/BENCHMARKS.md Outdated
Comment thread .gitlab/BENCHMARKS.md Outdated
@igoragoli
igoragoli force-pushed the augusto/flaky-benchmarks-monitoring-docs branch from b2b5a6b to bf73099 Compare October 1, 2026 13:30
@igoragoli

Copy link
Copy Markdown
Contributor Author

Nits resolved! Thank you for the review @xlamorlette-datadog :)

@igoragoli
igoragoli merged commit 7059aed into main Oct 1, 2026
33 of 37 checks passed
@igoragoli
igoragoli deleted the augusto/flaky-benchmarks-monitoring-docs branch October 1, 2026 13:36
@xlamorlette-datadog

Copy link
Copy Markdown
Collaborator

xlamorlette-datadog added a commit that referenced this pull request Oct 1, 2026
@xlamorlette-datadog

xlamorlette-datadog commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

@igoragoli I fixed it in an opened PR: 84fb898.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants